Fix campfire messages returning stale messages#371
Merged
Conversation
github-actions
bot
added
commands
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99caed71b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jeremy
force-pushed
the
decorous-general
branch
from
99caed7 to
79992d2
Compare
jeremy
changed the title
jeremy
force-pushed
the
decorous-general
branch
from
79992d2 to
05843bd
Compare
github-actions
bot
added
tui
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05843bd78a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jeremy
changed the title
jeremy
force-pushed
the
sdk-0.7.0
branch
4 times, most recently
from
d6a2cae to
6ea302a
Compare
jeremy
force-pushed
the
decorous-general
branch
from
05843bd to
c592c71
Compare
github-actions
bot
removed
tui
jeremy
force-pushed
the
sdk-0.7.0
branch
2 times, most recently
from
d2df13a to
6c0bca3
Compare
The chat messages command called ListLines with nil options, which fetches from page 1 (oldest messages) and caps at 100. The client-side reverse-slice then took the last N of the oldest 100 — yielding months-old messages for active campfires. Pass Sort/Direction options to request newest-first from the API, let the SDK handle the limit, and reverse to chronological order for display. Fixes #284
Verifies that chat messages sends sort=created_at&direction=desc to the API, respects --limit for truncation, and renders the response in chronological order (oldest to newest).
jeremy
force-pushed
the
decorous-general
branch
from
c592c71 to
9e4309f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat messagesreturned months-old messages for active campfires. The SDK'sListLineswith nil options fetches from page 1 (oldest), caps at 100, then the CLI reverse-sliced the last N of that stale batch.Sort: "created_at", Direction: "desc"toListLinesso the API returns newest messages first, let the SDK handle the limit, and reverse to chronological display order.Known debt: TUI paths (
hub_global.go:444,509,hub.go:729) also callListLines(..., nil)with incorrect "newest-first" comments. Out of scope — TUI is shelved.Fixes #284
Test plan
bin/cipasses (excluding pre-existingcheck-smoke-coveragefailure on main)basecamp chat messages --limit 3 --jsonreturns March 2026 messages in chronological order