Close smoke coverage gap from .surface alias expansion#378
Conversation
The .surface regeneration with alias support added 332 CMD entries for aliases that the smoke suite didn't account for. Add smoke_aliases.bats with group-level OOS markers that propagate to all leaf descendants, and add a chat show test to smoke_campfire.bats.
github-actions
bot
added
tests
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b53bf6a353
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
chat show is an alias for chat line which requires a positional ID arg. Mark it OOS since chat line is already tested.
There was a problem hiding this comment.
Pull request overview
This PR updates the smoke coverage accounting to include the expanded alias command paths introduced by the regenerated .surface, ensuring make check-smoke-coverage reports zero uncovered leaf commands.
Changes:
- Add a dedicated smoke file that marks alias-only command paths as out-of-scope (OOS) for coverage purposes.
- Add a smoke test intended to cover
chat showin the Campfire/Chat smoke suite.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| e2e/smoke/smoke_campfire.bats | Adds coverage for a chat show path in the chat/campfire smoke suite. |
| e2e/smoke/smoke_aliases.bats | Adds OOS markers to account for alias-expanded CMD entries in .surface for coverage checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
smoke_aliases.batswith OOS markers for all command aliases surfaced by the .surface regeneration in Regenerate .surface from Go walker with ARG and alias support #366chat showsmoke test tosmoke_campfire.batsThe .surface regen added alias support, registering every alias (
campfire→chat,docs→files, singular→plural,mv→move, etc.) as its own CMD entry. The smoke suite wasn't updated to match, leaving 223 commands uncovered and blockingmake release-check.Test plan
make check-smoke-coveragereports 0 uncoveredmake checkpasses