Skip to content

Restore - prefix on gradle-stop recipe#189

Merged
jeremy merged 1 commit intomainfrom
stop-gradle
Mar 16, 2026
Merged

Restore - prefix on gradle-stop recipe#189
jeremy merged 1 commit intomainfrom
stop-gradle

Conversation

@jeremy
Copy link
Copy Markdown
Member

@jeremy jeremy commented Mar 16, 2026

Summary

  • Restore - (ignore-error) prefix on both gradle-stop recipe lines so Make runs both ./gradlew --stop commands even if the first one fails

Addresses late review on #187: the - prefix was removed per Copilot's suggestion, but Cubic correctly pointed out that without it, a failure in the first command aborts Make before the second runs, leaving daemons alive.

Test plan

  • make gradle-stop runs both commands when the first fails (e.g. missing kotlin/ dir)

Summary by cubic

Restore the - ignore-error prefix on both commands in the gradle-stop recipe so make gradle-stop runs both ./gradlew --stop calls even if the first fails, preventing lingering Gradle daemons.

Written for commit 6e27a56. Summary will update on new commits.

@jeremy jeremy requested a review from a team as a code owner March 16, 2026 05:33
Copilot AI review requested due to automatic review settings March 16, 2026 05:33
@github-actions github-actions bot added the bug Something isn't working label Mar 16, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores Make’s “ignore error” (-) prefix on the gradle-stop target so both Gradle daemon stop commands are attempted even if one fails, ensuring daemons don’t linger due to early Make aborts.

Changes:

  • Re-add - prefix to the kotlin ./gradlew --stop line.
  • Re-add - prefix to the spec/smithy-bare-arrays ./gradlew --stop line.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@jeremy jeremy merged commit 1117791 into main Mar 16, 2026
53 checks passed
@jeremy jeremy deleted the stop-gradle branch March 16, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants