Conversation
There was a problem hiding this comment.
Pull request overview
Restores Make’s “ignore error” (-) prefix on the gradle-stop target so both Gradle daemon stop commands are attempted even if one fails, ensuring daemons don’t linger due to early Make aborts.
Changes:
- Re-add
-prefix to thekotlin./gradlew --stopline. - Re-add
-prefix to thespec/smithy-bare-arrays./gradlew --stopline.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-(ignore-error) prefix on bothgradle-stoprecipe lines so Make runs both./gradlew --stopcommands even if the first one failsAddresses late review on #187: the
-prefix was removed per Copilot's suggestion, but Cubic correctly pointed out that without it, a failure in the first command aborts Make before the second runs, leaving daemons alive.Test plan
make gradle-stopruns both commands when the first fails (e.g. missingkotlin/dir)Summary by cubic
Restore the
-ignore-error prefix on both commands in thegradle-stoprecipe somake gradle-stopruns both./gradlew --stopcalls even if the first fails, preventing lingering Gradle daemons.Written for commit 6e27a56. Summary will update on new commits.