Fix update methods silently dropping empty ID arrays

[robzolkos]

Summary

• Update methods across cards, card steps, todos, and schedule entries used len(slice) > 0 to guard writing assignee/participant/subscriber ID arrays into the request body. This caused empty slices ([]int64{}) — meaning "clear all" — to be silently omitted. The API interprets an absent field as "no change," so clearing the last assignee/participant/subscriber had no effect.
• Changed all affected guards from len(slice) > 0 to slice != nil, preserving the three-way semantics: nil = don't change, []int64{} = clear all, []int64{1,2} = set specific IDs.
• Affected: CardsService.Update (AssigneeIDs), CardStepsService.Update (Assignees), TodosService.Update (AssigneeIDs, CompletionSubscriberIDs), SchedulesService.UpdateEntry (ParticipantIDs)

Report: https://3.basecamp.com/2914079/buckets/46292715/card_tables/cards/9696883477

---

Summary by cubic

Fixes update methods that dropped empty ID arrays, so you can clear assignees, participants, and subscribers. Empty slices are now sent to the API; nil means no change.

• Bug Fixes
  • Preserve three-way semantics for ID arrays: nil = no change, [] = clear all, [1,2] = set IDs.
  • Applied to CardsService.Update (AssigneeIDs), CardStepsService.Update (Assignees), TodosService.Update (AssigneeIDs, CompletionSubscriberIDs), and SchedulesService.UpdateEntry (ParticipantIDs). Added tests to lock this behavior.
  • Added nil request guard to TodosService.Update to prevent nil-pointer panics and align with other services.

^{Written for commit b95c1d5. Summary will update on new commits.}

[Copilot]

Pull request overview

This PR fixes update semantics across the Go Basecamp SDK so that explicitly empty (but non-nil) ID slices are sent in update request bodies, allowing callers to “clear all” assignees/participants/subscribers rather than silently omitting the field and making no change.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Changes:

• Switch slice guards from len(slice) > 0 to slice != nil in update methods to preserve nil vs empty-slice semantics.
• Add/extend tests ensuring empty slices are encoded as empty arrays (e.g., "assignee_ids":[]) rather than omitted.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
go/pkg/basecamp/todos.go	Sends assignee_ids / completion_subscriber_ids whenever the slice is non-nil (including empty).
go/pkg/basecamp/todos_test.go	Adds tests asserting empty slices are present in the update request body for todos.
go/pkg/basecamp/schedules.go	Sends participant_ids whenever the slice is non-nil (including empty).
go/pkg/basecamp/schedules_test.go	Adds a test asserting empty participant IDs are sent in schedule entry updates.
go/pkg/basecamp/cards.go	Sends assignee_ids / assignees whenever the slice is non-nil (including empty).
go/pkg/basecamp/cards_test.go	Adds tests asserting empty assignee lists are sent for cards and card steps.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[cubic-dev-ai]

No issues found across 6 files