Install jq in make tools instead of printing a note#222
Merged
Conversation
jq is required by make check (sync-api-version-check), so leaving it as a note meant make setup wouldn't fully bootstrap the repo.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 800bb1c624
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Updates the repo bootstrap flow so make tools actively installs jq (a make check prerequisite) instead of only printing a note, improving “fresh clone” setup completeness.
Changes:
- Add
jqinstallation tomake toolsusing brew/pacman/apt-get with an error fallback.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add pip3 fallback for zizmor so apt-based distros aren't blocked - Move "Installing..." echo inside conditionals so it only prints when actually installing
github-actions
bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make checkdepends onjq(viasync-api-version-check), so leaving it as a NOTE meantmake setupwouldn't fully bootstrap the repoFollow-up to #219.
Test plan
make setupon a machine without jq installs itmake toolsskips jq if already presentSummary by cubic
Install
jqduringmake toolssomake setupfully bootstraps the repo. Preventsmake checkfailures whenjqis missing and tidies install output.jqviabrew,pacman, orapt-get; skips if present; errors if none.pip3fallback forzizmorand only prints "Installing..." when actually installing.Written for commit 09388a1. Summary will update on new commits.