Skip to content

Document PUT /my/profile.json endpoint#391

Merged
jeremy merged 3 commits intobasecamp:masterfrom
robzolkos:add-update-my-profile-docs
Mar 20, 2026
Merged

Document PUT /my/profile.json endpoint#391
jeremy merged 3 commits intobasecamp:masterfrom
robzolkos:add-update-my-profile-docs

Conversation

@robzolkos
Copy link
Copy Markdown
Contributor

Summary

  • Adds documentation for PUT /my/profile.json to sections/people.md
  • This endpoint exists in BC3 (My::ProfilesController#update) but was never documented, which caused it to be missed in the SDK generation pipeline
  • Documents all permitted parameters: name, email_address, title, bio, location, time_zone_name, first_week_day, time_format

The update profile endpoint exists in BC3 but was never documented,
which caused it to be missed in the SDK generation pipeline.
Copilot AI review requested due to automatic review settings March 12, 2026 18:39
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing API documentation for updating the authenticated user’s profile (PUT /my/profile.json) so the People documentation covers the full set of supported “my profile” operations and can be picked up by downstream SDK/doc tooling.

Changes:

  • Adds “Update my personal info” to the People endpoints list.
  • Documents PUT /my/profile.json, including optional parameters, expected status codes, and example JSON/cURL.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread sections/people.md
Copilot AI review requested due to automatic review settings March 20, 2026 08:54
@jeremy jeremy merged commit 986ddca into basecamp:master Mar 20, 2026
1 check passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sections/people.md
Comment on lines +294 to +296
###### Example JSON Request

```json
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request example for this PUT endpoint is missing the usual <!-- START PUT PAYLOAD ... --> / <!-- END PUT PAYLOAD ... --> markers used elsewhere in this file (and other sections) around JSON request payloads. Adding those markers helps keep the docs consistent and supports tooling that extracts example payloads.

Copilot uses AI. Check for mistakes.
Comment thread sections/people.md
Comment on lines +289 to +290
* `first_week_day` - the first day of the week (`0` for Sunday, `1` for Monday).
* `time_format` - time display format.
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first_week_day and time_format are documented here with different/value-less guidance than the /my/preferences.json docs immediately below (which show first_week_day as weekday names and time_format as twelve_hour/twenty_four_hour). Please align the accepted values (or explicitly explain why /my/profile.json differs) to avoid conflicting instructions.

Suggested change
* `first_week_day` - the first day of the week (`0` for Sunday, `1` for Monday).
* `time_format` - time display format.
* `first_week_day` - the first day of the week using weekday names (one of `sunday`, `monday`, `tuesday`, `wednesday`, `thursday`, `friday`, `saturday`).
* `time_format` - time display format, either `twelve_hour` or `twenty_four_hour`.

Copilot uses AI. Check for mistakes.
Comment thread sections/people.md
}
```
<!-- END PUT PAYLOAD /my/preferences.json -->

Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s an extra blank line between the <!-- END PUT PAYLOAD /my/preferences.json --> marker and the ###### Copy as cURL heading. In this file, other payload blocks place ###### Copy as cURL immediately after the END marker, so removing the blank line would keep formatting consistent.

Suggested change

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants