Skip to content

Privilege-separate AI labeler workflows#10

Merged
jeremy merged 2 commits intomainfrom
privsep
Mar 7, 2026
Merged

Privilege-separate AI labeler workflows#10
jeremy merged 2 commits intomainfrom
privsep

Conversation

@jeremy
Copy link
Copy Markdown
Member

@jeremy jeremy commented Mar 7, 2026

Summary

  • Replace inline classify and breaking-change AI labeler jobs with thin callers to centralized reusable workflows in basecamp/.github that separate inference from mutation

Privilege separation

Job Permissions Can do
infer models:read, contents:read Run AI inference, validate output
apply pull-requests:write, issues:write Apply labels, post comments

Test plan

  • Open a test PR to verify classify assigns the correct label
  • Verify breaking detection works on PRs touching Go library packages (credstore/, editor/, oauthcallback/, output/, pkce/, profile/, surface/)

…sions

AI labeler: replace inline jobs with thin callers to centralized reusable
workflows in basecamp/.github that separate inference from mutation.

Release: narrow per-job permissions to principle of least privilege.
Seed template: add environment gate to sync-skills and narrow permissions.

Ref: HackerOne #3585928
Copilot AI review requested due to automatic review settings March 7, 2026 20:54
@github-actions github-actions bot added the ci label Mar 7, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the PR AI labeler workflow to call centralized reusable workflows from basecamp/.github, aiming to separate AI inference from label/comment mutation while keeping this repo’s workflow thin.

Changes:

  • Replaced the inline classify job implementation with a call to basecamp/.github/.github/workflows/ai-classify-pr.yml.
  • Replaced the inline breaking job implementation with a call to basecamp/.github/.github/workflows/ai-breaking-change.yml.
  • Added inputs (prompt-file, labels, file-patterns) and job-level permissions for the reusable workflows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ai-labeler.yml Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c49161360

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ai-labeler.yml Outdated
This repo is a Go library, not a CLI — it has no internal/commands/ or
cmd/ directories. Use the actual exported package paths for breaking
change detection.
@jeremy jeremy merged commit 42ee1b0 into main Mar 7, 2026
18 checks passed
@jeremy jeremy deleted the privsep branch March 7, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants