Migrate webhook commands to SDK

[robzolkos]

Summary

• Migrates webhook show|create|update|delete|reactivate from the legacy HTTP client (getClient()) to the typed WebhooksService on the SDK account client.
• webhook list uses the typed service for the no-flag case and falls back to ac.Get / ac.GetAll for --page and --all, since the SDK's Webhooks().List doesn't accept a path. (webhook deliveries was already on the SDK and is untouched.)
• Behavior, flags, and CLI surface are unchanged — SURFACE.txt doesn't change. The e2e CRUD test in webhook_test.go continues to drive the same UX.

Notes

• Unit tests switched to the SetTestModeWithSDK httptest-backed pattern.
• Body assertions updated: SDK posts the typed request directly, so no more {"webhook": {...}} wrapper. URL assertions for get/update/delete drop the .json suffix to match the SDK paths (Rails accepts both forms).
• Create no longer needs a Location follow-up — WebhooksService.Create returns the full Webhook directly.

---

Summary by cubic

Migrates webhook CLI commands from the legacy HTTP client to the typed SDK for better type safety with the same CLI behavior. Also fixes list paging when using --all with --page.

• Refactors

  • Switched to SDK WebhooksService for show, create, update, delete, and reactivate.
  • list: uses Webhooks().List by default; falls back to ac.Get/ac.GetAll for --page/--all.
  • Request/response: removed "webhook" body wrapper; dropped .json paths; Create returns full Webhook (no Location follow-up); removed unused printSuccessWithLocation.
  • Tests now use SetTestModeWithSDK; assertions match new paths/payloads; errors via convertSDKError.

• Bug Fixes

  • webhook list --all --page N now starts from page N when fetching all results; added a unit test to lock this in.

^{Written for commit e83f22c. Summary will update on new commits. Review in cubic}

[cubic-dev-ai]

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/commands/webhook.go">

<violation number="1" location="internal/commands/webhook.go:59">
P2: `webhook list --all --page N` no longer honors the page flag, causing a behavior regression in pagination start point.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[github-actions]

⚠️ Potential breaking changes detected:

• Removal of the 'printSuccessWithLocation' function will impact any outputs or scripts relying on the specific functionality it provided.
• Modification of endpoint paths by removing '.json' suffixes (e.g., '/boards/board-1/webhooks/wh-1.json' changed to '/boards/board-1/webhooks/wh-1') may break scripts or integrations that expect the original URL format.
• Changes to the output of various commands (e.g., switching from 'resp.Data' to normalized data via 'normalizeAny') could affect scripts parsing the data, as the structure or content might differ.
• Replacement of manual API client methods (e.g., 'client.GetWithPagination' or 'client.Post') with SDK-generated methods (e.g., 'ac.Get' or 'ac.Webhooks().Activate') might alter behavior, particularly with error messages or returned data.

Review carefully before merging. Consider a major version bump.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.