Fix: not detecting mentions when publishing saved drafts #1767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that publishing a card with `#publish` was tracking the event after updating the status, which was clearing the saved changes and preventing the code from detecting the mention. See: https://app.fizzy.do/5986089/cards/2835
jorgemanrubia
commented
Dec 1, 2025
|
|
||
| # So that we can check it in callbacks when other operations in the transaction clean the changes. | ||
| def remember_initial_status | ||
| if will_save_change_to_status? |
jorgemanrubia
commented
Dec 1, 2025
|
|
||
| assert_difference -> { Mention.count }, +1 do | ||
| card.published! | ||
| card.publish |
Member
Author
There was a problem hiding this comment.
this was the reason why the test was passing, becuase it wasn't exercising the event tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that publishing a card with
#publishwas tracking the event after updating the status, which was clearing the saved changes and preventing the code from detecting the mention.See:
https://app.fizzy.do/5986089/cards/2835