Fix Japanese IME input handling for tag, step, and reaction fields#1984
Merged
flavorjones merged 1 commit intobasecamp:mainfrom Dec 8, 2025
Merged
Fix Japanese IME input handling for tag, step, and reaction fields#1984flavorjones merged 1 commit intobasecamp:mainfrom
flavorjones merged 1 commit intobasecamp:mainfrom
Conversation
When typing in Japanese, the Enter key is used to confirm kanji conversion during IME composition. Previously, pressing Enter would immediately save the tag, which prevented users from completing the conversion. Changes: - Add isComposing check to navigable_list_controller.js Enter handler - Add IME composition tracking to form_controller.js - Add compositionstart/compositionend event handlers to tag, step, and reaction input fields - Add preventComposingSubmit action to prevent form submission during composition This fix supports all IME input methods (Japanese, Chinese, Korean, etc.) using standard browser composition events.
Contributor
Author
|
@flavorjones , would you please review the changes or assign someone else for the review? |
Member
|
@gijigae Thanks! Someone will take a look this week. |
flavorjones
approved these changes
Dec 8, 2025
Member
flavorjones
left a comment
flavorjones
left a comment
There was a problem hiding this comment.
Thanks to @GabManette for testing this out!
Contributor
Author
|
Thank you both of you, @flavorjones and @GabManette, for reviewing and testing the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When typing in Japanese, the Enter key is used to confirm kanji conversion during IME composition. Previously, pressing Enter would immediately save the tag, which caused creating unintended tags. It addresses #1959.
Changes:
navigable_list_controller.jsEnter handlerform_controller.jspreventComposingSubmitaction to prevent form submission during composition