Notification spike #199
Merged
Notification spike #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And DRY up some duplication.
Otherwise Turbo falls back to a regular Browser navigation.
kevinmcconnell
force-pushed
the
notifs
branch
from
6b10ecd to
6479580
Compare
Previously when a notification was read, we'd remove it from the list. This will often be fine, but if there were more unread notifications that hadn't been loaded yet (because there were too many for the initial page) then the list could become empty when really there are still more items to show. So instead of removing the items when they're read, we can reload the list with the new page of items. This should allow the older notifications to come into view when necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't have the real UI yet, but I wanted to start assembling the parts we're likely to need. It has the basics of generating per-user notifications from the tracked events, broadcasting them, and dismissing them when the associated bubble is viewed.
Clicking on a notification takes you to the associated resource for that notification -- currently that's either the bubble or a specific comment.
cc @jzimdars
notification-tray.webm