Add JSON response support for `notifications/tray` by svara · Pull Request #2398 · basecamp/fizzy

svara · 2026-01-19T15:18:02Z

Updated notification/tray JSON for mobile app requirements:

Tray API now includes read notifications when include_unread=true
ETag varies by include_unread to avoid cache collisions
Added controller test for include_unread JSON

svara · 2026-01-19T15:20:09Z

app/views/notifications/_notification.json.jbuilder

-  json.creator notification.creator, partial: "users/user", as: :user
+  json.creator do
+    json.partial! "users/user", user: notification.creator
+    json.avatar_url user_avatar_url(notification.creator)


@jorgemanrubia Do you see any reason why we couldn't include the avatar url in the existing user partial?

cc @kevinmcconnell

@svara should be fine to add it to the user partial

alpkeser · 2026-01-29T07:35:06Z

app/controllers/notifications/trays_controller.rb

  def show
-    @notifications = Current.user.notifications.preloaded.unread.ordered.limit(100)
+    @notifications = unread_notifications
+    if include_unread?


@svara added this query parameter instead of checking for format.json. Let me know if you have any concerns.

@alpkeser I'm wondering if we'll ever need it, given the fact that we want unreads by default. cc @jayohms

I'm a bit confused. Don't both the web and mobile apps always want unread items here? And just the mobile apps also want read items for the json response? If we used a query param, wouldn't I expect this to be include_read?

doh, I meant read.

If we used a query param, wouldn't I expect this to be include_read?

Yes.

Sorry for confusing both of you, my bad. The param should named as include_read.

alpkeser · 2026-02-03T14:33:22Z

Hey @kevinmcconnell, I think we're done with the changes. Could you review this when you have a moment?

alpkeser · 2026-02-05T07:28:17Z

@jhutarek FYI, just deployed this branch to beta2.

app/controllers/notifications/trays_controller.rb

alpkeser · 2026-02-10T11:44:01Z

@monorkin and @kevinmcconnell I’ve rebased this branch on top of server-side-notification-grouping. I think we still need this endpoint for the apps, unless we want to incorporate these changes into the notifications endpoint.

alpkeser · 2026-02-10T12:34:12Z

I'm having trouble to deploy this branch to beta2. I'd appreciate some help 🙂
Enabling saas mode:
bin/rails saas:enable
Deploy:
bin/kamal deploy -d beta2
Output:

...
 INFO [d1c2a21e] Running docker run --detach --restart unless-stopped --name fizzy-web-beta2-df5057c84d1936fbb3d2e5708c685ed02f95bb1f --network kamal --hostname fizzy-beta-app-102.df-iad-int.37signals.com-372eeb641a5b --env KAMAL_CONTAINER_NAME="fizzy-web-beta2-df5057c84d1936fbb3d2e5708c685ed02f95bb1f" --env KAMAL_VERSION="df5057c84d1936fbb3d2e5708c685ed02f95bb1f" --env KAMAL_HOST="fizzy-beta-app-102.df-iad-int.37signals.com" --env KAMAL_DESTINATION="beta2" --env APP_FQDN="beta2.fizzy-beta.com" --env CACHE_NAMESPACE="2" --env RAILS_ENV="beta" --env RAILS_LOG_LEVEL="fatal" --env MYSQL_DATABASE_HOST="fizzy-mysql-primary" --env MYSQL_DATABASE_REPLICA_HOST="fizzy-mysql-replica" --env MYSQL_SOLID_CABLE_HOST="fizzy-mysql-primary" --env MYSQL_SOLID_QUEUE_HOST="fizzy-beta-solidqueue-db-102.df-iad-int.37signals.com" --env MYSQL_SOLID_CACHE_HOST="fizzy-beta-solidcache-db-101.df-iad-int.37signals.com" --env PRIMARY_DATACENTER="true" --env-file .kamal/apps/fizzy-beta2/env/roles/web.env --log-opt max-size="10m" --volume fizzy:/rails/storage --volume $PWD/.kamal/apps/fizzy-beta2/assets/volumes/web-df5057c84d1936fbb3d2e5708c685ed02f95bb1f:/rails/public/assets --label service="fizzy" --label role="web" --label destination="beta2" --label otel_scrape_enabled="true" registry.37signals.com/basecamp/fizzy:df5057c84d1936fbb3d2e5708c685ed02f95bb1f on fizzy-beta-app-102.df-iad-int.37signals.com
  INFO [d1c2a21e] Finished in 0.827 seconds with exit status 0 (successful).
  INFO [378fd265] Running docker container ls --all --filter name=^fizzy-web-beta2-df5057c84d1936fbb3d2e5708c685ed02f95bb1f$ --quiet on fizzy-beta-app-102.df-iad-int.37signals.com
  INFO [378fd265] Finished in 0.616 seconds with exit status 0 (successful).
  INFO [c20589d2] Running docker exec kamal-proxy kamal-proxy deploy fizzy-web-beta2 --target="ab4eb00f2ad8:80" --deploy-timeout="30s" --drain-timeout="30s" --buffer-requests --buffer-responses --log-request-header="Cache-Control" --log-request-header="Last-Modified" --log-request-header="User-Agent" on fizzy-beta-app-102.df-iad-int.37signals.com
 ERROR Failed to boot web on fizzy-beta-app-102.df-iad-int.37signals.com
  INFO First web container is unhealthy on fizzy-beta-app-102.df-iad-int.37signals.com, not booting any other roles
  INFO [60e6e9e1] Running docker container ls --all --filter name=^fizzy-web-beta2-df5057c84d1936fbb3d2e5708c685ed02f95bb1f$ --quiet | xargs docker logs --timestamps 2>&1 on fizzy-beta-app-102.df-iad-int.37signals.com
  INFO First web container is unhealthy, not booting jobs on fizzy-beta-jobs-102.df-iad-int.37signals.com
  INFO [60e6e9e1] Finished in 0.544 seconds with exit status 0 (successful).
 ERROR 
  INFO [3b5a6f84] Running docker container ls --all --filter name=^fizzy-web-beta2-df5057c84d1936fbb3d2e5708c685ed02f95bb1f$ --quiet | xargs docker inspect --format '{{json .State.Health}}' on fizzy-beta-app-102.df-iad-int.37signals.com
  INFO [3b5a6f84] Finished in 0.767 seconds with exit status 0 (successful).
 ERROR null
  INFO [2c86465a] Running docker container ls --all --filter name=^fizzy-web-beta2-df5057c84d1936fbb3d2e5708c685ed02f95bb1f$ --quiet | xargs docker stop on fizzy-beta-app-102.df-iad-int.37signals.com
  INFO [2c86465a] Finished in 10.907 seconds with exit status 0 (successful).
Releasing the deploy lock...
  Finished all in 127.6 seconds
  ERROR (SSHKit::Command::Failed): Exceptions on 2 hosts:
Exception while executing on host fizzy-beta-app-102.df-iad-int.37signals.com: docker exit status: 1
docker stdout: Nothing written
docker stderr: Error: target failed to become healthy within configured timeout (30s)

Exception while executing on host fizzy-beta-jobs-102.df-iad-int.37signals.com: Halted at barrier

monorkin · 2026-02-10T12:47:46Z

@alpkeser if you rebased this to my branch you should deploy to staging. Deploying to a beta could cause problems in production.

alpkeser · 2026-02-11T16:06:54Z

@monorkin and @kevinmcconnell I’ve rebased this branch on top of server-side-notification-grouping. I think we still need this endpoint for the apps, unless we want to incorporate these changes into the notifications endpoint.

Hey both, as we’re approaching to the launch, this PR along side with server-side-notification-grouping seems to be one of the last dependencies we need to get in. We’re aiming to have an internal release next Monday. I wanted to check if it works on your end timing-wise.

monorkin · 2026-02-12T09:59:09Z

@alpkeser I squashed the commits in the base branch, you might have to rebase and cherry-pick your commits to get a clean history (Claude is really grate at that if you explain to it what happened).

The #2512 is now live in production, so after you rebase, you can use the betas again for testing.

alpkeser · 2026-02-12T11:48:06Z

@alpkeser I squashed the commits in the base branch, you might have to rebase and cherry-pick your commits to get a clean history (Claude is really grate at that if you explain to it what happened).

The #2512 is now live in production, so after you rebase, you can use the betas again for testing.

Thank you for the heads up @monorkin 🙏 I'm on it.

Add avatar url, board name, and column.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Includes assignee users in the card object for display in notification UI. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

These fields were added but are not used by the iOS client. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

monorkin

@alpkeser great work on this!

I left a few suggestions on how we could improve render times in a few cases, and I had a question about the column field in notification.card.

app/models/notification.rb

app/views/notifications/_notification.json.jbuilder

app/views/cards/_card.json.jbuilder

app/views/notifications/_notification.json.jbuilder

alpkeser · 2026-02-16T15:02:14Z

@alpkeser great work on this!

I left a few suggestions on how we could improve render times in a few cases, and I had a question about the column field in notification.card.

Thank you for the review @monorkin 🙏

…estamps

alpkeser · 2026-02-17T14:35:52Z

Hey @monorkin, I wanted to double-check if there’s anything that needs a follow-up or if this one is good to go.

monorkin · 2026-02-17T15:30:37Z

@alpkeser we are good to go from my side

svara commented Jan 19, 2026

View reviewed changes

alpkeser force-pushed the notifications-tray-api branch 2 times, most recently from e6e395f to a3aefba Compare January 29, 2026 07:12

alpkeser marked this pull request as ready for review January 29, 2026 07:13

alpkeser requested a review from kevinmcconnell January 29, 2026 07:24

alpkeser force-pushed the notifications-tray-api branch from f604f0e to d954ec9 Compare January 29, 2026 07:26

alpkeser reviewed Jan 29, 2026

View reviewed changes

kevinmcconnell reviewed Feb 5, 2026

View reviewed changes

app/controllers/notifications/trays_controller.rb Show resolved Hide resolved

alpkeser force-pushed the notifications-tray-api branch from f99d54e to df5057c Compare February 10, 2026 11:39

alpkeser changed the base branch from main to server-side-notification-grouping February 10, 2026 11:40

alpkeser force-pushed the notifications-tray-api branch from df5057c to 21acb11 Compare February 11, 2026 15:53

monorkin force-pushed the server-side-notification-grouping branch 3 times, most recently from c799228 to 36ee253 Compare February 12, 2026 09:30

Base automatically changed from server-side-notification-grouping to main February 12, 2026 09:33

svara and others added 7 commits February 12, 2026 14:55

Add JSON response support for notifications/tray.

0b9869f

Extend notification JSON payload.

3dca00a

Add avatar url, board name, and column.

Add avatar_url to the shared user JSON partial.

af2efe6

Use the existing user partial on notifications.

683547e

Add has_attachments to notification card JSON

009e431

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Add card assignees to notification JSON

6809804

Includes assignee users in the card object for display in notification UI. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Remove unused has_attachments and assignees from notification JSON

a844353

These fields were added but are not used by the iOS client. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

alpkeser added 4 commits February 12, 2026 14:55

Include read notifications in the tray API response

80546a6

Add include_unread param to tray API and vary cache

b8793bf

Fix query parameter name

a6eb331

Add notification.source_type.underscore

b755522

alpkeser force-pushed the notifications-tray-api branch from 21acb11 to b755522 Compare February 12, 2026 11:56

Make notification ordering deterministic.

abcbb74

jhutarek mentioned this pull request Feb 12, 2026

Mobile / Postponed and closed flags in card JSONs #2537

Closed

Add postponed and closed flags to Pinned and Notification cards

c4c46cc

monorkin reviewed Feb 16, 2026

View reviewed changes

app/models/notification.rb Outdated Show resolved Hide resolved

app/views/notifications/_notification.json.jbuilder Show resolved Hide resolved

app/views/cards/_card.json.jbuilder Show resolved Hide resolved

app/views/notifications/_notification.json.jbuilder Show resolved Hide resolved

Preload notification card associations used by JSON responses

bcc0f93

alpkeser requested a review from monorkin February 16, 2026 15:02

Stabilize notifications tray test ordering via fixture updated_at tim…

a48c88c

…estamps

monorkin approved these changes Feb 17, 2026

View reviewed changes

alpkeser merged commit 610cf7a into main Feb 18, 2026
12 checks passed

alpkeser deleted the notifications-tray-api branch February 18, 2026 10:20

Conversation

svara commented Jan 19, 2026 • edited by alpkeser Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svara Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

svara Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

kevinmcconnell Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

alpkeser Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

svara Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

jayohms Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

svara Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

alpkeser Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alpkeser commented Feb 3, 2026

Uh oh!

alpkeser commented Feb 5, 2026

Uh oh!

Uh oh!

alpkeser commented Feb 10, 2026

Uh oh!

alpkeser commented Feb 10, 2026

Uh oh!

monorkin commented Feb 10, 2026

Uh oh!

alpkeser commented Feb 11, 2026

Uh oh!

monorkin commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alpkeser commented Feb 12, 2026

Uh oh!

monorkin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alpkeser commented Feb 16, 2026

Uh oh!

alpkeser commented Feb 17, 2026

Uh oh!

monorkin commented Feb 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

svara commented Jan 19, 2026 •

edited by alpkeser

Loading

alpkeser Jan 29, 2026 •

edited

Loading

alpkeser Feb 2, 2026 •

edited

Loading

monorkin commented Feb 12, 2026 •

edited

Loading