Skip to content

Cancellation section adjustments#2557

Merged
jzimdars merged 3 commits intobasecamp:mainfrom
nqst:cancellation-section-adjustments
Mar 3, 2026
Merged

Cancellation section adjustments#2557
jzimdars merged 3 commits intobasecamp:mainfrom
nqst:cancellation-section-adjustments

Conversation

@nqst
Copy link
Contributor

@nqst nqst commented Feb 17, 2026

This follows up on e892b74, where the Settings partials layout was updated. The Cancel account section wasn't included there, and here it's fixed.

Changes:

  • Updated the Cancel account section layout to match the other Settings partials.
  • Set the confirmation dialog width to match the Export dialog.
  • Added a missing comma: After 30 days, your data will be permanently deleted.

Preview:

Before After
before@2x after@2x
bef@2x aft@2x

@jorgemanrubia
Copy link
Member

Thanks @nqst.

This looks good to merge, what do you think @andyra @jzimdars?

@jzimdars
Copy link
Member

jzimdars commented Mar 3, 2026

The change above is fine since it addresses consistency with the other elements. However, I think we should follow this up with a different design altogether for this section.

It's just too repetitive. We don't need a heading followed by second line followed by a button that all essentially say the same thing. What to take a stab at that @nqst?

@jzimdars jzimdars merged commit 613dfa5 into basecamp:main Mar 3, 2026
5 checks passed
@nqst
Copy link
Contributor Author

nqst commented Mar 3, 2026

We don't need a heading followed by second line followed by a button that all essentially say the same thing. Want to take a stab at that @nqst?

@jzimdars I absolutely agree, and I'd love to redesign that! I'll work on it and open a PR.

@nqst nqst deleted the cancellation-section-adjustments branch March 3, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants