Mobile / Search scrolling + clear button suggestion#2640
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the search UI behavior for mobile/perma search to improve scrolling behavior and refine the “clear” interaction by moving input-clearing logic into a dedicated Stimulus controller and adjusting when the clear button is shown.
Changes:
- Added a
search-formStimulus controller to handle clearing/focusing the search input and to emit aclearevent. - Updated
bar#clearInputto react to the dispatched clear event (reset only when the input is already empty). - Adjusted CSS to hide/show the clear button based on whether the search input is empty, and tweaked native overscroll behavior for
.search.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/views/searches/_form.html.erb | Wires the form/input/reset button to the new search-form controller and adds an (hidden) submit button. |
| app/javascript/controllers/search_form_controller.js | New controller that clears the search input and dispatches a clear event with state. |
| app/javascript/controllers/bar_controller.js | Simplifies clearInput to reset only when the search-form reports the input is already empty. |
| app/assets/stylesheets/search.css | Changes clear button visibility rules in .search-perma to depend on input emptiness. |
| app/assets/stylesheets/native.css | Overrides .search overscroll behavior for native platform styling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* main: Extract event particulars helper method Reapply "Push event payload body updates" Bump z-index Bump z-index dep: Fix up Gemfile.saas.lock
…lear-suggestion * mobile/search-scrolling: Extract event particulars helper method Reapply "Push event payload body updates" Bump z-index Bump z-index dep: Fix up Gemfile.saas.lock
jayohms
reviewed
Mar 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jorgemanrubia
approved these changes
Mar 3, 2026
* main: Mobile: improve search screen (#2636) Document has_attachments in API card responses (#2523) Change exceeding and nearing limits to account for the 1000th card (#2345) Include concrete example motivating this module file Simplify comment in skip-detached override Extract detached-blob guard into its own file Skip AnalyzeJob when blob has no attachments Allow notice to take more inline space Fix small documentation typos Display the save form button on Board Settings page as a bridge button billing.rb: destroy -> destroy! Strip whitespace from webhook URLs Add test for webhook URL with trailing whitespace
…lear-suggestion * mobile/search-scrolling: Mobile: improve search screen (#2636) Document has_attachments in API card responses (#2523) Change exceeding and nearing limits to account for the 1000th card (#2345) Include concrete example motivating this module file Simplify comment in skip-detached override Extract detached-blob guard into its own file Skip AnalyzeJob when blob has no attachments Allow notice to take more inline space Fix small documentation typos Display the save form button on Board Settings page as a bridge button billing.rb: destroy -> destroy! Strip whitespace from webhook URLs Add test for webhook URL with trailing whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.