Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Hotwire Native Bridge “stamp” component so the native layer can display card status (“Done” / “Not Now”) with associated metadata, along with styling tweaks to improve the mobile/perma layout.
Changes:
- Wrap the “Done” and “Not Now” stamp markup with
data-controller="bridge--stamp"and exposebridge_title,bridge_date, andbridge_byvia data attributes. - Extend
BridgeElementwithgetStamp()(plusgetDate()/getBy()) and introduce a newbridge/stamp_controllerto send the stamp payload over the bridge. - Update native/mobile CSS positioning and perma-card styling to accommodate the stamp layout.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/views/cards/display/common/_stamp.html.erb | Adds bridge controller + data attributes for native stamp payload. |
| app/javascript/initializers/bridge/bridge_element.js | Adds getStamp() and helpers to read new bridge attributes. |
| app/javascript/controllers/bridge/stamp_controller.js | New bridge component controller that sends stamp payload on connect/disconnect. |
| app/assets/stylesheets/native.css | Adjusts native perma-card spacing and background/border treatments. |
| app/assets/stylesheets/card-perma.css | Adjusts mobile stamp positioning and removes some mobile-only perma padding rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jayohms
reviewed
Mar 17, 2026
Contributor
Author
|
@jayohms I realized that the web stamp view is also used in the boards which means dozens of stamps trying to connect to the bridge when you visit a board page. |
…as been marked as "Not Now"
…onnect" messages will be sent
* main: (43 commits) Remove payment/subscription system and card/storage limits Conditionally disable peer verification for ZIP streaming Prevent HTML injection through filenames Revert "Configure Lexxy to add extra spacing between block elements" Configure Lexxy to add extra spacing between block elements SaaS usage reporting (#2690) Update app/models/user/named.rb Prevent line breaks in the middle of familiar_name Tweak the layout Set the list of importable models based on the record sets in the manifest Validate polymorphic types against importable models allowlist Fix that the "maybe" stream wouldn't be replaced after triaging a card Use x_user_agent cookie for platform detection in Hotwire Native Add JSON response format to entropy endpoints (#2673) Fix path traversal vulnerability in ActiveStorage blob key import Enable CORS fetch mode for storage requests Revert CORS fetch mode for Active Storage Use CORS fetch mode for Active Storage to enable `maxEntrySize` checks Only start offline mode when signed in Exclude service worker and edit/pin/watch/new pages from main cache ...
jayohms
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.