Fix broken background image after removal#2817
Merged
flavorjones merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
flavorjones
force-pushed
the
broken-background-image
branch
from
050660b to
bdea68f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
flavorjones
force-pushed
the
broken-background-image
branch
from
bdea68f to
0f1ec73
Compare
flavorjones
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ActiveStorage::Record and ApplicationRecord used separate connection pools (from separate `connects_to` calls). This meant `belongs_to touch: true` on attachments silently failed — the card couldn't join the attachment's transaction to receive the deferred touch, so fragment caches were never invalidated after image removal. Fix by delegating `connection_pool` from ActiveStorage::Record to ApplicationRecord so they share a single pool.
flavorjones
force-pushed
the
broken-background-image
branch
from
0f1ec73 to
03a3576
Compare
Member
Author
|
Tested in staging, looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActiveStorage::RecordandApplicationRecordused separate connection pools (from separateconnects_tocalls), sobelongs_to touch: trueon attachments silently failed — the card couldn't join the attachment's transaction to receive the deferred touchconnection_poolfromActiveStorage::RecordtoApplicationRecordso they share a single pool, and the existingtouch: truemechanism works as intendedTest plan
purgeandpurge_latertouch the card'supdated_at