Scope clear_search_records to the account being destroyed

[flavorjones]

Account::Searchable#clear_search_records called
Search::Record.for(id).destroy_all which deleted every row in the shard's table, wiping search records belonging to every other account that happened to hash to the same shard.

ref: #2804
ref: https://3.basecamp.com/2914079/buckets/27/card_tables/cards/9782824728

[Copilot]

Pull request overview

This PR fixes account incineration so clearing sharded Search::Record entries only deletes records belonging to the account being destroyed, preventing cross-account data loss when multiple accounts hash to the same shard.

Changes:

• Scope Account::Searchable#clear_search_records to where(account_id: id) before destroy_all.
• Add a regression test that simulates a shard collision and asserts only the doomed account’s search records are removed.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
test/models/account/incineratable_test.rb	Adds coverage ensuring incineration only clears the account’s own sharded search records while preserving others on the same shard.
app/models/account/searchable.rb	Fixes the deletion query to be account-scoped within the shard to avoid wiping other accounts’ search records.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.