Remove basecamp -> basecamp-cli cask rename#2
Merged
Conversation
The rename mapped the token `basecamp` to `basecamp-cli`, but `basecamp` collides with the official Basecamp desktop-app cask in homebrew/cask. Users with the desktop app installed who ran `brew install basecamp/tap/basecamp-cli` hit Homebrew treating the installed desktop app as an old basecamp-cli, then failing to purge `/Applications/Basecamp 3.app`. Dropping the rename stops Homebrew conflating the desktop app with the CLI. Document the explicit --cask install and a reinstall recovery command for the small number of early adopters who installed the CLI as `basecamp` (v0.7.0). Fixes basecamp/basecamp-cli#477
There was a problem hiding this comment.
Pull request overview
This PR removes the basecamp → basecamp-cli cask rename to prevent Homebrew from mistakenly attempting to migrate/purge the official homebrew/cask Basecamp desktop app when users install the Basecamp CLI from this tap, and updates the README with clearer installation/recovery guidance.
Changes:
- Removed
cask_renames.jsonto eliminate thebasecamptoken collision-driven migration behavior. - Updated
README.mdto documentbrew install --cask basecamp/tap/basecamp-cliand a recovery-oriented reinstall flow.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Clarifies cask-specific install and adds recovery guidance for prior installs/migration errors. |
| cask_renames.json | Removes the rename mapping that caused collisions with the official desktop-app cask. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users running the documented
brew install basecamp/tap/basecamp-clihit:Root cause. This tap's
cask_renames.jsonmapped the tokenbasecamp→basecamp-cli. The rename was legitimate — the CLI was first published here as the cask tokenbasecamp(v0.7.0), then renamed tobasecamp-cliin bc7a916 — and was meant to auto-migrate those early installs.But
basecampcollides with the official Basecamp desktop-app cask inhomebrew/cask. When a user with the desktop app tapsbasecamp/tapand installs the CLI, Homebrew sees the rename, treats the installed desktop-appbasecampas an oldbasecamp-cli, tries to migrate/upgrade it, and fails purging the desktop app's artifacts (/Applications/Basecamp 3.app, gone after upgrading to Basecamp.app 5.x).Fix
cask_renames.jsonso Homebrew stops conflating the desktop app with the CLI. (Homebrew treats a missing file as "no renames".)README.mdto document the explicit--caskinstall and abrew reinstallrecovery command.Casks/basecamp-cli.rbis untouched (it's GoReleaser-owned and already correct).Trade-off (accepted)
The handful who installed the CLI as
basecamp/tap/basecamp(v0.7.0) lose auto-migration; they re-install asbasecamp-cli(covered by the README recovery note). The desktop-app collision — affecting far more users — is eliminated. The CLI is brand new (0.7.0 → 0.7.2), so the migration population is tiny.Verification
brew readall basecamp/tapparses the tap cleanly (no output, no errors).brew audit --cask --tap basecamp/tap basecamp-cliexits 0.homebrew/caskbasecamp(desktop app) is no longer matched tobasecamp/tap/basecamp-cli, so the install proceeds cleanly instead of attempting the desktop-app migration/purge.Fixes basecamp/basecamp-cli#477