Skip to content

Conversation

@samuelpecher
Copy link
Collaborator

@samuelpecher samuelpecher commented Nov 24, 2025

  • Append the element to lexxy-editor rather than body
  • use display: none;

cc @jzimdars

* Attach the element to lexxy rather than body
* use display: none;
@jzimdars
Copy link
Member

Thanks for this, @samuelpecher! Do you think this should have a CSS class so it can be handled differently depending on the situation/app? I can't tell from the code comment if this is actually the element that gets triggered or if it's just an implementation wart.

I'm also slightly concerned about display: none. In the past I've run into trouble when completely hiding inputs that need to be triggered programmatically. Usually we have to do some kind of position:absolute shenanigans to keep it iteractive.

Thoughts?

Copy link
Member

@jorgemanrubia jorgemanrubia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this does the job I think it is fine @jzimdars. This is a transient control that should not be visible at all, it just exists to show the dialog. I think this should be fine. Thanks @samuelpecher 🙏

@jorgemanrubia jorgemanrubia merged commit d46e6b7 into main Nov 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants