Fix image captions with colons being stripped by DOMPurify#488
Merged
samuelpecher merged 1 commit intobasecamp:mainfrom Jan 20, 2026
Merged
Fix image captions with colons being stripped by DOMPurify#488samuelpecher merged 1 commit intobasecamp:mainfrom
samuelpecher merged 1 commit intobasecamp:mainfrom
Conversation
Collaborator
|
No objections to the principle. We're not using those values except storing them in the rich text. @packagethief can I get your 👀 on this? |
Member
|
No objections here 👍 |
lylo
force-pushed
the
fix-caption-colon-stripping
branch
from
23a0d1b to
67e4d51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOMPurify validates attribute values against a URI regex unless the attribute is marked as "URI safe". The
captionattribute was inALLOWED_ATTRbut not inURI_SAFE_ATTRIBUTES, causing values like "photographer: name" to be stripped because the colon made it look like an unknown protocol scheme.Adding
captionandfilenametoADD_URI_SAFE_ATTRprevents this validation, allowing any text content in these attributes.