Sanitize styles in markup pasted as markdown#635
Merged
samuelpecher merged 2 commits intomainfrom Jan 21, 2026
Merged
Conversation
samuelpecher
force-pushed
the
pasted-plain-markup
branch
from
dd325d3 to
741c097
Compare
- Add PASTE_TAG for all clipboard operations - Encode pasted plain_text with to_json - Test for pasted markup in text/plain
samuelpecher
force-pushed
the
pasted-plain-markup
branch
from
741c097 to
7640cfc
Compare
samuelpecher
force-pushed
the
pasted-plain-markup
branch
from
7640cfc to
eed8826
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
insertHtmlso sanitization occurs.<span>and plain-text markup.Fixes #602, thanks @lylo
cc @packagethief
There's a slight imbalance of abstractions. It would be nicer to not call
editor.update()from the clipboard handler, or alternatively call it every time consistently. Not calling it would require passingclipboardDatatoContents, leaking the abstraction. Callingeditor.update()everywhere will result in a better-avoided nested update when callinginsertHtml. The compromise is passing a tag toinsertHtmlto apply to the update.