Conversation
Links become non-editable with target="_blank" while the platform modifier key is held (Cmd on macOS, Ctrl elsewhere), allowing the browser to handle link navigation natively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make links non-editable while ctrl/cmd is held, allowing the browser to handle link navigation natively.
A simple click handler intercepting
cmd/ctrl+clickand callingwindow.openworks for opening links, but it doesn't give the user any visual feedback on hover. Tracking modifier key state for cursor styling separately gets messy because browsers don't always provide truthful values for pointer events when the key was initially held in a non-browser window.By toggling
contenteditablewe rely on native browser behavior and ensure visual feedback matches behavior in all edge cases.