Skip to content

added chrome theme change#122

Merged
dhh merged 1 commit into
basecamp:masterfrom
pukljak:chrome-theme-change
Jun 13, 2024
Merged

added chrome theme change#122
dhh merged 1 commit into
basecamp:masterfrom
pukljak:chrome-theme-change

Conversation

@pukljak
Copy link
Copy Markdown
Contributor

@pukljak pukljak commented Jun 13, 2024

Google Chrome theme can be change when the whole theme is changed, then you need to confirm that you want to change theme in chrome, and chrome restarts.

If somebody thinks that can found better matching colors for chrome, fill free to send config and we can change it easily.

Closes #65

@dhh dhh merged commit 2b7f4fc into basecamp:master Jun 13, 2024
@pukljak pukljak deleted the chrome-theme-change branch June 13, 2024 19:01
@dhh
Copy link
Copy Markdown
Member

dhh commented Jun 13, 2024

The background only changes correctly on the first theme change. Subsequent theme changes do not change the background.

@dhh
Copy link
Copy Markdown
Member

dhh commented Jun 13, 2024

Also, pkill gives you a "Chrome didn't shut down correctly" error when it restarts.

@pukljak
Copy link
Copy Markdown
Contributor Author

pukljak commented Jun 13, 2024

When you refresh the page or open new tab, background do not change also?

@dhh
Copy link
Copy Markdown
Member

dhh commented Jun 13, 2024

So we kill Chrome, and then it starts again. When it starts again, it's not the new background.

@pukljak
Copy link
Copy Markdown
Contributor Author

pukljak commented Jun 13, 2024

Actually do not know what is the problem, I tried multiple time on my laptop and it works.

About force kill, that is the only way a menage to change theme, if it is only pkill, or pkill -f, it do not change anything.

@dhh
Copy link
Copy Markdown
Member

dhh commented Jun 13, 2024

Think maybe you need to do pkill -f, but then wait until the process is actually dead. Otherwise there's a race condition.

@pukljak
Copy link
Copy Markdown
Contributor Author

pukljak commented Jun 13, 2024

You were right about waiting for process to finish, but that only solved the problem with "Chrome didn't shut down correctly", but not with loading new background on restart chrome.

Also find out, when in settings under "On startup" when its selected "Open the New Tab page" then background its loaded instantly. Only when it's selected "Continue where you left off" then it needs to reload current page or open new tab.
I assume that is because that option, chrome opens "old" config, but that is just my guess.

I am trying to find that option to be "force" reloaded, but unsuccessfully for now.

burno-lima pushed a commit to burno-lima/omakdot that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync theme with Chrome theme extension

2 participants