Skip to content

Adds unzip dependency required by install/fonts.sh#19

Merged
dhh merged 1 commit into
basecamp:masterfrom
snth:patch-1
Jun 6, 2024
Merged

Adds unzip dependency required by install/fonts.sh#19
dhh merged 1 commit into
basecamp:masterfrom
snth:patch-1

Conversation

@snth
Copy link
Copy Markdown
Contributor

@snth snth commented Jun 6, 2024

This might already be a required by one of the packages on Ubuntu 24.04 but in my Ubuntu 22.04 WSL2 trial unzip wasn't available when it was needed.

@dhh
Copy link
Copy Markdown
Member

dhh commented Jun 6, 2024

I don't want to get into supporting earlier than 24.04 versions of ubuntu, if we can help it. I won't have any means of testing it on a regular basis. Maybe we should code in a hardstop asking for 24.04+ instead.

@snth
Copy link
Copy Markdown
Contributor Author

snth commented Jun 6, 2024

I hear you on the point about not taking on the burden of supporting a different Ubuntu version. However if you look at the PR, it's just adding unzip alongside your other tool dependencies and unzip is clearly needed by your fonts.sh script. IDK which package is making unzip available on 24.04 but it appears to be just a happy coincidence that it occurs earlier than the fonts install. IMHO it would make your process more robust by adding it explicitly in install.sh or fonts.sh because if it's already available at that point then it's almost a noop anyway.

@dhh
Copy link
Copy Markdown
Member

dhh commented Jun 6, 2024

I see what you mean. Fair enough.

@dhh dhh merged commit a279b0e into basecamp:master Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants