Minor refactor of 2 bin scripts since they where bugging me#21
Conversation
added 2 commits
June 6, 2024 23:32
jeremy
requested changes
Jun 7, 2024
added 2 commits
June 7, 2024 09:05
Author
|
your requested changes are now present and imo it looks great now |
dhh
reviewed
Jun 7, 2024
added 2 commits
June 7, 2024 16:11
get latest version, for developing a new way to do gnome exts
dhh
reviewed
Jun 8, 2024
dhh
reviewed
Jun 8, 2024
dhh
reviewed
Jun 8, 2024
| esac | ||
|
|
||
| code --install-extension "${VSC_THEME##* }" > /dev/null | ||
| sed -i "s/\"workbench.colorTheme\": \".*\"/\"workbench.colorTheme\": \"${VSC_THEME% *}\"/g" ~/.config/Code/User/settings.json |
Member
There was a problem hiding this comment.
I find using a single string too clever here. Makes it harder to read.
added 2 commits
June 8, 2024 08:56
Author
|
I've tried to at least fix the problem by simplifying the sed command, but I don't fully understand the problem you are facing |
ghost
requested a review
from 
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.