Implement omarchy-launch-editor with state-based preference#1048
Closed
jardahrazdera wants to merge 1 commit into
Closed
Implement omarchy-launch-editor with state-based preference#1048jardahrazdera wants to merge 1 commit into
jardahrazdera wants to merge 1 commit into
Conversation
Implements DHH's requested approach for customizable editor support: - omarchy-launch-editor reads preference from ~/.local/state/omarchy/default/editor - omarchy-set-editor provides menu interface for selecting default editor - Supports both terminal editors (nvim, vim, nano, micro, helix) and GUI editors (code, codium, zed, sublime) - Replaces hardcoded nvim in omarchy-menu with omarchy-launch-editor - Adds Editor option to Setup menu for easy configuration This approach avoids Hyprland env limitations and allows runtime editor changes without session restart. Fixes basecamp#634 Related to basecamp#808
Member
|
The great @vaxerski has implemented live ENVs for Hyprland! So on the next release, we'll be able to set EDITOR in top-level envs and be able to rely on that instead of manual state files. Going to hold off for that instead. Thanks for pursuing this, though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements customizable editor support as discussed in #634 and requested by @dhh.
@logannc initially proposed this feature in PR #808. DHH requested a different approach using state files instead of Hyprland environment variables to avoid session restarts.
This PR implements DHH's requested approach:
Supports terminal editors (nvim, vim, nano, micro, helix) and GUI editors (code, codium, zed, sublime).
Fixes #634
Thanks to @logannc for the initial idea and groundwork in #808.