Skip to content

Remove localized directory paths#1248

Closed
kromsam wants to merge 1 commit into
basecamp:masterfrom
kromsam:xdg_dir_fix
Closed

Remove localized directory paths#1248
kromsam wants to merge 1 commit into
basecamp:masterfrom
kromsam:xdg_dir_fix

Conversation

@kromsam
Copy link
Copy Markdown

@kromsam kromsam commented Aug 28, 2025

This is an alternative to: #1244

This PR only removes the localized directory paths from the shell script.

XDG_PICTURES_DIR and XDG_VIDEOS_DIR are equal to $HOME/Pictures and $HOME/Videos. It is good practice not to hard-code localized directory name in scripts.

@abenz1267
Copy link
Copy Markdown
Contributor

I'd still advocate for removing the omarchy specific envvars. No application will check those. Every application will query the XDG ones.

@kromsam
Copy link
Copy Markdown
Author

kromsam commented Aug 28, 2025

I'd still advocate for removing the omarchy specific envvars. No application will check those. Every application will query the XDG ones.

but we should offer a way to change the screenshot path right... there is no XDG standard for it.

otherwise people will set XDG_PICTURES_DIR to their Screenshots folder, which would be a bad idea

@abenz1267
Copy link
Copy Markdown
Contributor

I think there's a misunderstanding of what those directories are: they define the default locations for their intention. Those variables are used by "every" application.

That's like changing the download dir to use some custom envvar, while every program uses the XDG one.

You can set XDG_PICTURES_DIR to Pictures/Screenshots or whatever, if you want to use Pictures for more than default application handling.

@dhh
Copy link
Copy Markdown
Member

dhh commented Sep 14, 2025

Yeah, I don't think we need to get that granular on the setup. Appreciate the suggestion but going to keep it simple for now.

@dhh dhh closed this Sep 14, 2025
@kromsam
Copy link
Copy Markdown
Author

kromsam commented Sep 22, 2025

Hm, fine for now but I dont understand it. using freedesktop standards is gonna make this project easier to maintain and to tweak with in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants