Fix DNS migration to handle UseDNS=no in network files#1314
Merged
Conversation
Issue basecamp#1246: Migration 1755109182.sh only fixes resolved.conf but doesn't remove UseDNS=no from network files. When UseDNS=no persists, it blocks DHCP DNS and forces fallback to Cloudflare after reboot. Fix: Remove UseDNS=no from all network files, matching omarchy-setup-dns DHCP behavior.
Fixes DNS issue for users who already ran migration 1755109182.sh. Removes UseDNS=no from network files to enable DHCP DNS.
Member
|
Let's just combine the entire cleanup in the new migration. Just wanted to catch that some folks will have run the old one. But once you add a new name, you'll get everyone. |
dhh
reviewed
Aug 30, 2025
|
|
||
| # Migration to fix DNS issue for existing users who already ran 1755109182.sh | ||
| # Remove UseDNS=no from all network files to allow DHCP DNS | ||
| # This matches what omarchy-setup-dns DHCP does |
Member
There was a problem hiding this comment.
Remove both bash and comments. Style is just a single echo at the top. No need for other echos during progress either unless things fail.
- Revert 1755109182.sh to original state - Consolidate all fixes in new migration 1756491748.sh - Follow migration style guidelines
hamidriaz1998
pushed a commit
to hamidriaz1998/omarchy
that referenced
this pull request
Sep 8, 2025
* Fix DNS migration to handle UseDNS=no in network files Issue basecamp#1246: Migration 1755109182.sh only fixes resolved.conf but doesn't remove UseDNS=no from network files. When UseDNS=no persists, it blocks DHCP DNS and forces fallback to Cloudflare after reboot. Fix: Remove UseDNS=no from all network files, matching omarchy-setup-dns DHCP behavior. * Add new migration 1756491748.sh for existing users Fixes DNS issue for users who already ran migration 1755109182.sh. Removes UseDNS=no from network files to enable DHCP DNS. * Apply requested changes - Revert 1755109182.sh to original state - Consolidate all fixes in new migration 1756491748.sh - Follow migration style guidelines
chriopter
pushed a commit
to chriopter/omarchy
that referenced
this pull request
Nov 18, 2025
* Fix DNS migration to handle UseDNS=no in network files Issue basecamp#1246: Migration 1755109182.sh only fixes resolved.conf but doesn't remove UseDNS=no from network files. When UseDNS=no persists, it blocks DHCP DNS and forces fallback to Cloudflare after reboot. Fix: Remove UseDNS=no from all network files, matching omarchy-setup-dns DHCP behavior. * Add new migration 1756491748.sh for existing users Fixes DNS issue for users who already ran migration 1755109182.sh. Removes UseDNS=no from network files to enable DHCP DNS. * Apply requested changes - Revert 1755109182.sh to original state - Consolidate all fixes in new migration 1756491748.sh - Follow migration style guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1246
Reopening the DNS fix since the previous PR #1271 got closed accidentally.
Migration 1755109182.sh only fixed resolved.conf but didn't remove UseDNS=no from network files, causing DNS to revert to Cloudflare after reboot.
This adds:
Both now match what omarchy-setup-dns DHCP does.
Tested and confirmed it fixes the issue.