Enable audio settings to use default terminal emulator#325
Closed
apdingman wants to merge 1 commit into
Closed
Conversation
Contributor
|
the problem is that you can't target the wiremix window via windowrules like that, in omarchy's case: to make it float by default. |
Author
@abenz1267 You're absolutely right. I missed the windowrules portion of the implementation. I don't see a great alternative for this beyond hardcoding the terminal emulator and passing the title and class options. |
Member
|
I think we need something like a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we're defaulting the audio settings to open using Alacritty. However, if the someone has chosen to go ahead and pivot to a different terminal emulator (i.e. ghostty), then this is the experience upon opening the audio settings from walker.
This change does remove the use of the
--classand--titleoptions, but removing those seems inconsequential. My experience was the same with both of these configurations:Obviously those options serve a purpose for setting the window class and title, but I don't see the immediate need here.
Certainly open for discussion. Just looking to help out those that have pivoted from Alacritty already so that they can access their audio settings without issue.