Update migration to ensure walker is refreshed after finder prefix was added.#425
Merged
dhh merged 2 commits intoAug 1, 2025
Merged
Conversation
…er prefixes in the file. Also mod walker prefix to use double quotes for consistency to match the others.
Member
|
Yeah, actually best to rename this migration to something newer, then it'll run again for everyone that ran the last one (that didn't do the right thing). |
Contributor
Author
|
Great idea, I hadn't thought of that. Thanks! |
cdub615
pushed a commit
to cdub615/omarchy
that referenced
this pull request
Aug 2, 2025
…s added. (basecamp#425) * Update migration that looks for prefix with '.' as it matches the other prefixes in the file. Also mod walker prefix to use double quotes for consistency to match the others. * Rename fixed migration to ensure it runs again for all users
chriopter
pushed a commit
to chriopter/omarchy
that referenced
this pull request
Nov 18, 2025
…s added. (basecamp#425) * Update migration that looks for prefix with '.' as it matches the other prefixes in the file. Also mod walker prefix to use double quotes for consistency to match the others. * Rename fixed migration to ensure it runs again for all users
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the conditional in the 1753910761.sh migration was returning true due to the other prefixes.
Because of this, the
omarchy-refresh-walkercommand was never fired and theconfig.tomlwhich included theprefix = "."was never updated.This PR:
Please let me know if it's frowned upon for updating older migrations. This really only solves it for those who haven't yet updated to 1.8.0.
Should I make a new migration that has the fix instead?