Remove Fcitx5 autostart desktop entry#4752
Merged
dhh merged 1 commit intobasecamp:devfrom Feb 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves a duplicate startup issue where Fcitx5 (an input method framework) was being launched twice: once through the XDG autostart mechanism via /etc/xdg/autostart/org.fcitx.Fcitx5.desktop and once explicitly through the Hyprland autostart configuration. The PR removes the XDG autostart desktop entry to prevent the duplication, keeping only the explicit Hyprland startup.
Changes:
- Added a migration script to remove the Fcitx5 XDG autostart desktop entry for existing installations
- Created a new configuration script that performs the removal operation
- Integrated the removal script into the main configuration pipeline for fresh installations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| migrations/1772120972.sh | Migration script that executes the Fcitx5 autostart removal for existing systems |
| install/config/remove-fcitx5-autostart.sh | Configuration script that removes the XDG autostart desktop entry file |
| install/config/all.sh | Adds the removal script to the main configuration pipeline |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out we are starting fcitx5 twice. This PR removes the autostart desktop entry.