Forward WAYLAND_DISPLAY environment variable so clipboard works inside tmux#4800
Open
joaoptpsa wants to merge 3 commits intobasecamp:devfrom
Open
Forward WAYLAND_DISPLAY environment variable so clipboard works inside tmux#4800joaoptpsa wants to merge 3 commits intobasecamp:devfrom
joaoptpsa wants to merge 3 commits intobasecamp:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates tmux’s attach-time environment propagation so panes see current display/session variables after reattaching, restoring clipboard integration in Wayland/X11 setups.
Changes:
- Append
WAYLAND_DISPLAY,DISPLAY,XDG_SESSION_TYPE, andDBUS_SESSION_BUS_ADDRESSto tmuxupdate-environmentso they refresh on client attach.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When tmux starts its server, it captures the environment at launch time. Attaching later from a new login leaves WAYLAND_DISPLAY/DISPLAY stale inside panes, causing wl-copy, wl-paste, and xclip to fail silently. set -ag update-environment tells tmux to refresh these variables on every client attach, so clipboard tools always find the correct socket. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
DISPLAY is already in tmux's compiled-in defaults. Only add the three variables that are genuinely missing: WAYLAND_DISPLAY, XDG_SESSION_TYPE, and DBUS_SESSION_BUS_ADDRESS. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
DISPLAY is in tmux's compiled-in defaults. wl-copy/wl-paste use WAYLAND_DISPLAY directly so XDG_SESSION_TYPE and DBUS_SESSION_BUS_ADDRESS are not needed for clipboard support. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4962f77 to
1102616
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tmux's default
update-environmentlist doesn't includeWAYLAND_DISPLAYcausingwl-copyandwl-pasteto fail.Check defaults with:
Fix
See tmux(1)
NB:
XDG_SESSION_TYPEmight be useful for other applications.Sorry for the small commit spam!— First time contributor and First time doing this from CLI with Claude.
Let me know if you want me to open a separate clean PR.