Skip to content

Fix omarchy-windows-vm username/password handling for dollar signs#4882

Open
ajkingio wants to merge 1 commit intobasecamp:devfrom
ajkingio:dev
Open

Fix omarchy-windows-vm username/password handling for dollar signs#4882
ajkingio wants to merge 1 commit intobasecamp:devfrom
ajkingio:dev

Conversation

@ajkingio
Copy link

@ajkingio ajkingio commented Mar 3, 2026

The Issue

omarchy-windows-vm doesn't escape $ symbols in passwords so it thinks they are variables. It sets a chopped up version of the password in the Windows VM but uses the full password you passed in the docker compose file.

I noticed these messages during the omarchy-windows-vm install process, which tipped me off.

Starting Windows VM with docker-compose...
WARN[0000] The "t3rD" variable is not set. Defaulting to a blank string.
WARN[0000] The "R" variable is not set. Defaulting to a blank string.

So the manual fix was:

  1. omarchy-windows-vm remove
  2. omarchy-windows-vm install
  3. Use a password without dollar signs.

The Fix

Fixed omarchy-windows-vm to properly handle $ in usernames/passwords by escaping dollar signs before writing docker-compose.yml, so Docker Compose doesn’t treat them as variable interpolation. Then on launch, it unescapes when reading credentials back for RDP login. This keeps the Windows account password and the stored compose config consistent.

Copilot AI review requested due to automatic review settings March 3, 2026 00:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants