Fix omarchy-windows-vm username/password handling for dollar signs#4882
Open
ajkingio wants to merge 1 commit intobasecamp:devfrom
Open
Fix omarchy-windows-vm username/password handling for dollar signs#4882ajkingio wants to merge 1 commit intobasecamp:devfrom
ajkingio wants to merge 1 commit intobasecamp:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
omarchy-windows-vm doesn't escape $ symbols in passwords so it thinks they are variables. It sets a chopped up version of the password in the Windows VM but uses the full password you passed in the docker compose file.
I noticed these messages during the omarchy-windows-vm install process, which tipped me off.
So the manual fix was:
omarchy-windows-vm removeomarchy-windows-vm installThe Fix
Fixed omarchy-windows-vm to properly handle $ in usernames/passwords by escaping dollar signs before writing docker-compose.yml, so Docker Compose doesn’t treat them as variable interpolation. Then on launch, it unescapes when reading credentials back for RDP login. This keeps the Windows account password and the stored compose config consistent.