Skip to content

Add CI validation harness using Github Actions.#490

Closed
folone wants to merge 1 commit into
basecamp:masterfrom
folone:gl/ci-validation
Closed

Add CI validation harness using Github Actions.#490
folone wants to merge 1 commit into
basecamp:masterfrom
folone:gl/ci-validation

Conversation

@folone
Copy link
Copy Markdown

@folone folone commented Aug 4, 2025

Adds some basic linters/checkers to make it easier to sanity-check contributions.

Note: shellcheck had a bunch of complaints about the existing migrations. I've chosen to ignore these by filtering out everything before the latest migration 1754228679 inclusively. Meaning, new migrations will run through the shellcheck.

The rest of the changes to the migrations files is just making them executable and replacing ~ with $HOME.

See an example of this workflow running in my fork here folone#1

Screenshot 2025-08-04 at 21 48 01

@folone folone changed the title Add CI validation harness (and fix some issues). Add CI validation harness using Github Actions. Aug 4, 2025
@folone folone marked this pull request as ready for review August 4, 2025 20:52
@dhh
Copy link
Copy Markdown
Member

dhh commented Aug 5, 2025

Thanks for investigating this! I'd actually very much like a CI system, but I don't want it to be a linter, I want it to be a tester. None of the checks added here are something I've seen be an issue in either Omarchy or Omakub. But if you can find a way to actually run a complete install of Omarchy and verify that it boots correctly, I'm very interested in that. Please do open another PR if you get there!

@dhh dhh closed this Aug 5, 2025
@folone
Copy link
Copy Markdown
Author

folone commented Aug 5, 2025

if you can find a way to actually run a complete install of Omarchy and verify that it boots correctly

Good idea – let me see if we can do something with containers 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants