Add CI validation harness using Github Actions.#490
Closed
folone wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for investigating this! I'd actually very much like a CI system, but I don't want it to be a linter, I want it to be a tester. None of the checks added here are something I've seen be an issue in either Omarchy or Omakub. But if you can find a way to actually run a complete install of Omarchy and verify that it boots correctly, I'm very interested in that. Please do open another PR if you get there! |
Author
Good idea – let me see if we can do something with containers 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some basic linters/checkers to make it easier to sanity-check contributions.
Note:
shellcheckhad a bunch of complaints about the existing migrations. I've chosen to ignore these by filtering out everything before the latest migration1754228679inclusively. Meaning, new migrations will run through theshellcheck.The rest of the changes to the migrations files is just making them executable and replacing
~with$HOME.See an example of this workflow running in my fork here folone#1