Add ASUS TUF laptop support for asusctl and keyboard RGB#5020
Open
ki11e6 wants to merge 2 commits intobasecamp:devfrom
Open
Add ASUS TUF laptop support for asusctl and keyboard RGB#5020ki11e6 wants to merge 2 commits intobasecamp:devfrom
ki11e6 wants to merge 2 commits intobasecamp:devfrom
Conversation
- Add omarchy-hw-asus-tuf detection script for TUF Gaming laptops - Include TUF in asusctl auto-install packaging - Add mode cycle workaround in keyboard theme script for TUF hardware that requires flushing color changes via mode switch Closes basecamp#5019
ki11e6
force-pushed
the
fix/asus-tuf-keyboard-rgb
branch
from
7e568b6 to
6306014
Compare
Hardware color accuracy is limited on TUF keyboards but asusctl sets the color correctly. Only TUF detection and asusctl auto-install needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omarchy-hw-asus-tufdetection script for TUF Gaming laptops (TUFin product_family)asusctlauto-install packaging alongside ROGThe existing
omarchy-theme-set-keyboard-asus-rogscript works as-is on TUF hardware — no changes needed there. The only issue is thatasusctlis never auto-installed becauseomarchy-hw-asus-rogdoesn't detect TUF laptops.Closes #5019
Test plan
omarchy-hw-asus-tufreturns true on TUF laptops and false on non-TUFasusctlis auto-installed on TUF laptops during setup