Replace Impala with nettui for network controls#5040
Replace Impala with nettui for network controls#5040skibidiandulka wants to merge 3 commits intobasecamp:devfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76d587e75f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if omarchy-cmd-missing nettui; then | ||
| omarchy-pkg-add nettui |
There was a problem hiding this comment.
This migration only installs nettui and removes impala, but it never enables systemd-networkd, even though the same commit adds sudo systemctl enable systemd-networkd.service for fresh installs in install/config/hardware/network.sh. Upgraded systems do not execute installer scripts, so users who update in place can end up with nettui installed but the required network backend still disabled, which breaks or severely limits the new network-control flow (especially Ethernet management).
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75fb1db81b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
migrations/1773693740.sh
Outdated
| if omarchy-cmd-present impala; then | ||
| omarchy-pkg-drop impala |
There was a problem hiding this comment.
This migration removes impala even when omarchy-pkg-add nettui fails, because the add step's status is never used to guard the later drop path. In upgrade scenarios where nettui cannot be installed (e.g., repo lag or transient pacman failure), users lose their only network TUI and bin/omarchy-migrate will still mark this migration complete if subsequent commands succeed, so it will not be retried automatically.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
This PR replaces Impala with nettui as Omarchy's network TUI.
Why
Omarchy currently routes its top-bar network action to a Wi-Fi-only TUI.
nettuikeeps the same iwd-first approach, but extends it into a single network TUI for both Wi-Fi and Ethernet.This project is heavily inspired by Impala and intentionally stays close to Impala's interaction model and backend philosophy.
It is not meant to replace that model with something foreign. If anything, nettui is much closer to an Impala-derived network TUI than to a clean-sheet rewrite: the same general Wi-Fi workflow, extended with integrated Ethernet support and Omarchy-specific polish.
What changed
impalawithnettuiininstall/omarchy-base.packagesomarchy-launch-wifito launchnettuiWifitoNetworkWifi controlstoNetwork controlsorg.omarchy.nettuisystemd-networkd.servicein the network setup pathnettuiand removesimpaladocs/network-click-behavior.mdWhy this is a better fit for Omarchy
Important note
This PR requires
nettuito be published inpkgs.omarchy.orgbefore merge.Without that package source, replacing
impalain the Omarchy installer would break the official install path.Nettui is available at: https://github.com/skibidiandulka/nettui/