Migrate existing waybar configs to pin battery to BAT0#5369
Merged
Conversation
Follow-up to #4918: that PR updated the default template, but existing users keep their copy at ~/.config/waybar/config.jsonc and won't pick up the fix without running omarchy-refresh-waybar (which wipes local customizations). Patch the existing file in place and restart waybar.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new migration to update existing user Waybar configs so the battery module is pinned to BAT0, preventing Waybar crashes caused by transient HID power supplies (e.g., Logitech/Apple devices disconnecting).
Changes:
- Introduce a migration that inserts
"bat": "BAT0"into~/.config/waybar/config.jsoncwhen missing. - Restart Waybar after applying the config change.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Per Copilot review: grep/sed patterns now match "battery" : {,
"battery":{, and "bat" : "..." variants that hand-edited configs
may use. Also only restart waybar when a battery block actually
exists to edit.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4918.
That PR pinned
"bat": "BAT0"in the default waybar template, which fixes new installs.This migration patches existing configs in place.
Tested
diffreturns empty)."bat": "BAT1"or another value — thegrepguard short-circuits beforesedruns.omarchy-restart-waybarsucceeds.