Skip to content

Add laptop display mirror toggle + hotkey#5462

Merged
dhh merged 7 commits intobasecamp:devfrom
timbelmon:hotfix#5457
Apr 29, 2026
Merged

Add laptop display mirror toggle + hotkey#5462
dhh merged 7 commits intobasecamp:devfrom
timbelmon:hotfix#5457

Conversation

@timbelmon
Copy link
Copy Markdown
Contributor

Added a check to see if any monitor is mirroring the internal display. If mirroring is detected, the script stops before disabling the screen.

Copilot AI review requested due to automatic review settings April 27, 2026 11:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@timbelmon
Copy link
Copy Markdown
Contributor Author

Issue: #5457
First commit to the project—edits and feedback are welcome

@dhh
Copy link
Copy Markdown
Member

dhh commented Apr 29, 2026

How does this situation occur? Why would you want to mirror an internal display if you're also closing that display?

@timbelmon
Copy link
Copy Markdown
Contributor Author

How does this situation occur? Why would you want to mirror an internal display if you're also closing that display?

I have my internal display mirrored at all times for giving presentations with a projector. But I also have an external display at my desk which I plug into and then close my laptop.
Usually this wouldn't be a problem if you keep updating your config for each use but of course people are lazy.

@dhh
Copy link
Copy Markdown
Member

dhh commented Apr 29, 2026

Ahhh. I see. I think we should do two things: 1) Fix the crash bug in Hyprland (I alerted vaxry) and 2) Have a toggle for mirroring like we do for turning the internal display on/off.

@timbelmon
Copy link
Copy Markdown
Contributor Author

Ahhh. I see. I think we should do two things: 1) Fix the crash bug in Hyprland (I alerted vaxry) and 2) Have a toggle for mirroring like we do for turning the internal display on/off.

How would a toggle work in regards to multiple outputs? Mirror the internal display to all of them?
But yes checking for a toggle is much cleaner than this solution I agree.

@dhh
Copy link
Copy Markdown
Member

dhh commented Apr 29, 2026

Yes, was thinking that again we treat the internal monitor as authoritative, mirror to everything that's connected. 9/10 times it'll just be a projector or a single extra monitor anyway.

- Implement `omarchy-hyprland-monitor-internal-mirror` to dynamically mirror the internal eDP display to external monitor.
- Update `omarchy-hyprland-monitor-internal` to prevent disabling the laptop screen if mirroring is currently active.
- Add "Mirror Display" toggle to omarchy hardware Menu
@timbelmon
Copy link
Copy Markdown
Contributor Author

Updated as Suggested; works pretty good on my end.
Please double-check if this is inline with your code requirements.

Copilot AI review requested due to automatic review settings April 29, 2026 18:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings April 29, 2026 18:18
@dhh dhh changed the title Add check for active external monitors before disabling internal display; fixes #5457 Add laptop display mirror toggle + hotkey Apr 29, 2026
@dhh dhh merged commit 35789cc into basecamp:dev Apr 29, 2026
2 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants