Allow Docker DNS from 192.168 networks#5465
Merged
dhh merged 2 commits intobasecamp:devfrom Apr 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands Omarchy’s UFW rules so Docker containers on Docker-allocated 192.168.0.0/16 networks can reach the host’s Docker DNS resolver (172.17.0.1:53/udp), and adds a migration to apply the same rule to existing installs.
Changes:
- Add an additional UFW allow rule for Docker DNS traffic sourced from
192.168.0.0/16during first-run firewall setup. - Add a migration to add the same UFW rule on existing systems.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
install/first-run/firewall.sh |
Adds a second Docker DNS UFW allow rule for the 192.168.0.0/16 Docker address pool. |
migrations/1777282771.sh |
Migration intended to backfill the new Docker DNS UFW rule onto existing installs. |
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5464