Skip to content

Allow Docker DNS from 192.168 networks#5465

Merged
dhh merged 2 commits intobasecamp:devfrom
davzucky:allow-docker-dns-192
Apr 29, 2026
Merged

Allow Docker DNS from 192.168 networks#5465
dhh merged 2 commits intobasecamp:devfrom
davzucky:allow-docker-dns-192

Conversation

@davzucky
Copy link
Copy Markdown
Contributor

Summary

  • Allow Docker DNS requests from Docker's documented 192.168.0.0/16 default address pool.
  • Add a migration so existing UFW-enabled installs receive the same rule.

Fixes #5464

Copilot AI review requested due to automatic review settings April 27, 2026 12:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands Omarchy’s UFW rules so Docker containers on Docker-allocated 192.168.0.0/16 networks can reach the host’s Docker DNS resolver (172.17.0.1:53/udp), and adds a migration to apply the same rule to existing installs.

Changes:

  • Add an additional UFW allow rule for Docker DNS traffic sourced from 192.168.0.0/16 during first-run firewall setup.
  • Add a migration to add the same UFW rule on existing systems.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
install/first-run/firewall.sh Adds a second Docker DNS UFW allow rule for the 192.168.0.0/16 Docker address pool.
migrations/1777282771.sh Migration intended to backfill the new Docker DNS UFW rule onto existing installs.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread migrations/1777282771.sh Outdated
@dhh dhh merged commit 8589167 into basecamp:dev Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker DNS firewall rule does not cover Docker default 192.168 address pool

3 participants