Fix screenshot cancel cleaning stale hyprpicker#5514
Fix screenshot cancel cleaning stale hyprpicker#5514afurm wants to merge 2 commits intobasecamp:devfrom
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18a4f0c234
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@afurm thanks, but I wanted to do on my own |
Summary
slurpandhyprpickerwhen cancelling an in-progress or stale screenshot capture.Why
Fixes #5506.
If a screenshot run is force-killed before its EXIT trap runs,
hyprpickercan keep the frozen overlay alive. Pressing the screenshot key again only killedslurp, so the stale overlay remained.Validation
bash -n bin/omarchy-capture-screenshotgit diff --check