Skip to content

Fix screenshot cancel cleaning stale hyprpicker#5514

Open
afurm wants to merge 2 commits intobasecamp:devfrom
afurm:af/fix-screenshot-stale-hyprpicker
Open

Fix screenshot cancel cleaning stale hyprpicker#5514
afurm wants to merge 2 commits intobasecamp:devfrom
afurm:af/fix-screenshot-stale-hyprpicker

Conversation

@afurm
Copy link
Copy Markdown
Contributor

@afurm afurm commented Apr 30, 2026

Summary

  • Exact-match screenshot helper process cleanup.
  • Kill both slurp and hyprpicker when cancelling an in-progress or stale screenshot capture.

Why

Fixes #5506.

If a screenshot run is force-killed before its EXIT trap runs, hyprpicker can keep the frozen overlay alive. Pressing the screenshot key again only killed slurp, so the stale overlay remained.

Validation

  • bash -n bin/omarchy-capture-screenshot
  • Mocked early-cancel run
  • git diff --check

Copilot AI review requested due to automatic review settings April 30, 2026 17:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18a4f0c234

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bin/omarchy-capture-screenshot Outdated
@afurm afurm requested a review from Copilot April 30, 2026 17:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dphov
Copy link
Copy Markdown

dphov commented May 1, 2026

@afurm thanks, but I wanted to do on my own

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

omarchy-capture-screenshot toggle leaves stale hyprpicker overlay after crash

3 participants