Fix: read files from symlink directory in background selector menu#5524
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Omarchy background selector provider to correctly list images when the theme’s user backgrounds directory (~/.config/omarchy/backgrounds/<theme>) is a symlink to another directory (e.g., ~/Pictures/Wallpapers).
Changes:
- Add a helper to resolve a theme backgrounds path to its symlink target via
realpath. - Use the resolved path (when available) when building the list of directories scanned for images.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR adds support for listing images from a symlink directory, having same name as the theme name within the
~/.config/omarchy/backgroundsdirectory.Scenario:
If we have a common wallpapers directory at
~/Pictures/Wallpapers.And we create symlink for this directory in
~/.config/omarchy/backgroundswith correct theme name convention like:ln -s ~/Pictures/Wallpapers ~/.config/omarchy/backgrounds/lumon, OR,ln -s ~/Pictures/Wallpapers ~/.config/omarchy/backgrounds/tokyo-nightThe omarchy background selector menu does not show the images from the symlinked directory.

The update in this PR adds support for:
Listing the default theme backgrounds, and
Images from the symlink directory