Skip to content

Fix: read files from symlink directory in background selector menu#5524

Merged
dhh merged 3 commits intobasecamp:devfrom
tushar-chauhan:fix-read-symbolik-link-bg-selector
May 1, 2026
Merged

Fix: read files from symlink directory in background selector menu#5524
dhh merged 3 commits intobasecamp:devfrom
tushar-chauhan:fix-read-symbolik-link-bg-selector

Conversation

@tushar-chauhan
Copy link
Copy Markdown
Contributor

This PR adds support for listing images from a symlink directory, having same name as the theme name within the ~/.config/omarchy/backgrounds directory.

Scenario:
If we have a common wallpapers directory at ~/Pictures/Wallpapers.
And we create symlink for this directory in ~/.config/omarchy/backgrounds with correct theme name convention like:

  • ln -s ~/Pictures/Wallpapers ~/.config/omarchy/backgrounds/lumon, OR,
  • ln -s ~/Pictures/Wallpapers ~/.config/omarchy/backgrounds/tokyo-night

The omarchy background selector menu does not show the images from the symlinked directory.
before-symlink-fix

The update in this PR adds support for:

  • Listing the default theme backgrounds, and

    • screenshot-2026-05-01_16-04-00
  • Images from the symlink directory

    • screenshot-2026-05-01_16-03-25

Copilot AI review requested due to automatic review settings May 1, 2026 11:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Omarchy background selector provider to correctly list images when the theme’s user backgrounds directory (~/.config/omarchy/backgrounds/<theme>) is a symlink to another directory (e.g., ~/Pictures/Wallpapers).

Changes:

  • Add a helper to resolve a theme backgrounds path to its symlink target via realpath.
  • Use the resolved path (when available) when building the list of directories scanned for images.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread default/elephant/omarchy_background_selector.lua Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread default/elephant/omarchy_background_selector.lua Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dhh dhh merged commit 21f712c into basecamp:dev May 1, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants