Use packaged Dell XPS touchpad haptics#5534
Use packaged Dell XPS touchpad haptics#5534jacob-vincent-mink wants to merge 4 commits intobasecamp:devfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes the Dell XPS Synaptics haptic touchpad daemon configurable via a user config file, adds hardware detection + setup/update commands for intensity, and exposes the control via the Omarchy Setup menu (with a migration for existing installs).
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Add Dell XPS haptic touchpad detection plus setup/update commands to manage intensity.
- Update the haptic daemon + systemd service wiring to read the desktop user’s config path via an EnvironmentFile.
- Extend
Setup > Inputto include a Dell haptics entry (and migrate existing installs to the new service wiring).
Reviewed changes
Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| migrations/1777653181.sh | Migrates existing Dell XPS installs to refresh the service and apply the configurable path. |
| install/config/hardware/dell/fix-xps-haptic-touchpad.sh | Updates the systemd unit to optionally load /etc/omarchy-dell-haptic-touchpad.env and uses the new hardware detector. |
| bin/omarchy-update-dell-haptic | New command to write intensity config + env file and restart/reset trackpad/service. |
| bin/omarchy-setup-dell-haptic-touchpad | New interactive/setup wrapper (gum input) around the update command. |
| bin/omarchy-menu | Adds an Input submenu and exposes “Touchpad Haptics” on supported Dell systems. |
| bin/omarchy-hw-dell-xps-haptic-touchpad | New hardware detection helper for Dell XPS Synaptics haptic touchpads. |
| bin/omarchy-haptic-touchpad | Reads intensity from user config and supports runtime refresh via mtime/SIGHUP. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This is great! But I'd like to do the following:
|
|
Thanks for the feedback @dhh! 30/60/90 works for low/medium/high? Or - any other opinion on which levels made the touchpad feel better? I’ll get on this after I finish travels in a day. |
|
I haven't actually tried, but let's just try with that? I'll tweak them after trying it on the real hardware. |
|
@dhh I've updated omacom-io/omarchy-pkgs#86 towards your feedback and have updated this PR to use it. After messing around with the numbers on my system, I found 10/50/100 to be more "obvious" when toggling, but you might find different. |
# Conflicts: # bin/omarchy-menu
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 10 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
omarchyand into the newdell-xps-touchpad-hapticspackage in OPRToggle > Hardware > Touchpad HapticsDetails
omarchywithomarchy-hw-dell-xps-haptic-touchpadinstall/packaging/dell-xps-touchpad-haptics.shomarchy-toggle-touchpad-haptics, which cycles these preset levels:lowmidhighToggle > Hardware > Touchpad HapticsMigration
dell-xps-haptic-touchpad.servicedell-xps-touchpad-hapticsomarchy-pkgsDependency
omacom-io/omarchy-pkgs#86Testing
bash -n bin/omarchy-hw-dell-xps-haptic-touchpad bin/omarchy-toggle-touchpad-haptics bin/omarchy-menu install/packaging/dell-xps-touchpad-haptics.sh migrations/1777653181.shgit diff --checkHardware test
omarchy-pkgsPATH="$HOME/src/github.com/jacob-vincent-mink/omarchy/bin:$PATH" omarchy-toggle-touchpad-haptics