Add bass speaker fix for Lenovo Yoga Pro 7 14IAH10#5597
Merged
dhh merged 3 commits intobasecamp:devfrom May 7, 2026
Merged
Conversation
The ALC287 codec on Yoga Pro 7 14IAH10 requires the alc287-yoga9-bass-spk-pin quirk to properly route audio to both amplifier speakers. Without this fix, only one speaker works and bass output is missing. This adds: - Hardware detection script (omarchy-hw-lenovo-yoga-pro7-bass) - Audio fix that creates /etc/modprobe.d/lenovo-yoga-pro7-bass.conf Tested on Lenovo Yoga Pro 7 14IAH10 (Intel Core Ultra 9 285H). Reference: https://wiki.archlinux.org/title/Lenovo_Yoga_9i_2022_(14AiPI7)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a hardware-specific audio quirk for the Lenovo Yoga Pro 7 14IAH10 by detecting the model via DMI and writing a modprobe configuration to enable the correct ALC287 pin routing (restoring the missing/bass speaker output).
Changes:
- Add a hardware detection helper (
omarchy-hw-lenovo-yoga-pro7-bass) usingomarchy-hw-match. - Add a Lenovo-specific installer hardware script that writes
/etc/modprobe.d/lenovo-yoga-pro7-bass.confwith the requiredsnd-sof-intel-hda-genericoption.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| install/config/hardware/lenovo/fix-yoga-pro7-bass-speakers.sh | Writes the required modprobe option when the target Yoga Pro 7 model is detected. |
| bin/omarchy-hw-lenovo-yoga-pro7-bass | Adds a DMI-based detection command for the specific Lenovo Yoga Pro 7 14IAH10 model. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Addresses review feedback: the hardware fix script was not invoked during installation. Add it to install/config/all.sh so it runs automatically on matching hardware.
dhh
reviewed
May 5, 2026
| # Without this quirk, only one speaker works and bass output is missing. | ||
| # Reference: https://wiki.archlinux.org/title/Lenovo_Yoga_9i_2022_(14AiPI7) | ||
|
|
||
| if omarchy-hw-lenovo-yoga-pro7-bass; then |
Member
There was a problem hiding this comment.
Let's just inline the hw-match call here. Since it's only used here.
dhh
reviewed
May 5, 2026
| run_logged $OMARCHY_INSTALL/config/hardware/apple/fix-suspend-nvme.sh | ||
| run_logged $OMARCHY_INSTALL/config/hardware/apple/fix-t2.sh | ||
|
|
||
| run_logged $OMARCHY_INSTALL/config/hardware/lenovo/fix-yoga-pro7-bass-speakers.sh |
Member
There was a problem hiding this comment.
We should also add a migration so existing machines get the fix.
| # Without this quirk, only one speaker works and bass output is missing. | ||
| # Reference: https://wiki.archlinux.org/title/Lenovo_Yoga_9i_2022_(14AiPI7) | ||
|
|
||
| if omarchy-hw-match "Yoga Pro 7 14IAH10"; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Lenovo Yoga Pro 7 14IAH10 has dual amplifier speakers (AMP1 + AMP2) that require a specific pin quirk for the ALC287 codec. Without this fix, only one speaker works and bass output is missing.
Solution
This PR adds hardware detection and audio configuration for the Yoga Pro 7 14IAH10:
bin/omarchy-hw-lenovo-yoga-pro7-bassinstall/config/hardware/lenovo/fix-yoga-pro7-bass-speakers.shThe fix creates
/etc/modprobe.d/lenovo-yoga-pro7-bass.confwith:Testing
Tested on Lenovo Yoga Pro 7 14IAH10 with Intel Core Ultra 9 285H. Both speakers now work correctly with proper bass output.
Reference
Based on the same fix used for Lenovo Yoga 9i 2022: https://wiki.archlinux.org/title/Lenovo_Yoga_9i_2022_(14AiPI7)#Audio