fix: resolve relative wallpaper paths before creating symlink#5612
Merged
dhh merged 1 commit intobasecamp:devfrom May 6, 2026
Merged
fix: resolve relative wallpaper paths before creating symlink#5612dhh merged 1 commit intobasecamp:devfrom
dhh merged 1 commit intobasecamp:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where relative wallpaper paths produced broken symlinks.
The script was passing the user-provided path directly to
ln -s, which caused relative paths to be resolved relative to the symlink location instead of the caller's current working directory.This change resolves the provided path with
realpathbefore creating the symlink.Before:
Would create a broken symlink inside: ~/.config/omarchy/current/background
After: The symlink correctly points to the absolute resolved image path.