Skip to content

Add weather location setup option#5714

Open
NjengaFelix wants to merge 1 commit into
basecamp:devfrom
NjengaFelix:feat/weather-location-setup
Open

Add weather location setup option#5714
NjengaFelix wants to merge 1 commit into
basecamp:devfrom
NjengaFelix:feat/weather-location-setup

Conversation

@NjengaFelix
Copy link
Copy Markdown

@NjengaFelix NjengaFelix commented May 9, 2026

Summary

This PR shares a weather location setup configuration:
#5707

  • add Setup -> Weather -> Location
  • add omarchy-setup-weather-location to set/clear a user-defined location
  • update omarchy-weather-status to use an override when configured, while keeping default auto-detection unchanged

Files changed

  • bin/omarchy-menu — add Setup -> Weather -> Location menu flow
  • bin/omarchy-setup-weather-location — new command to set/clear weather location
  • bin/omarchy-weather-status — read configured location override with fallback behavior

Behavior and compatibility

  • default behavior remains unchanged when no location is configured (wttr.in auto-detection)
  • canonical path used in this PR: ~/.config/omarchy/weather/location
  • compatibility fallback read path: ~/.config/omarchy/weather-location
  • no migration included because this is additive and non-breaking

Clarification needed

Maintainer decision requested

I’ve used ~/.config/omarchy/weather/location as the canonical path in this PR, and would appreciate maintainer confirmation on the preferred long-term convention.

Why

wttr.in auto-location can sometimes resolve to coordinates or unstable location names depending on ISP/VPN/routing. This adds a deterministic user override without requiring edits in ~/.local/share/omarchy.

Expose a Setup -> Weather -> Location flow and let weather status honor a user-defined location while preserving auto-detect defaults and legacy compatibility.
Copilot AI review requested due to automatic review settings May 9, 2026 19:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NjengaFelix NjengaFelix requested a review from Copilot May 9, 2026 20:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@NjengaFelix NjengaFelix requested a review from Copilot May 9, 2026 20:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants