fix hypridle.conf#641
Conversation
|
We have a number of these fixes in there already. I also don't think the extra comments on time carry their weight. Could you slim it down and we can look at what's left? Thanks! |
e297e84 to
a5bc404
Compare
|
Done |
125b829 to
a63db89
Compare
|
I see that |
a63db89 to
17234fd
Compare
|
Should this be rebased? @marcinczenko |
17234fd to
7445ccc
Compare
7445ccc to
a84059e
Compare
|
Sure, done. |
| timeout = 330 # 5.5min | ||
| on-timeout = hyprctl dispatch dpms off # screen off when timeout has passed | ||
| on-resume = hyprctl dispatch dpms on && brightnessctl -r # screen on when activity is detected | ||
| timeout = 30 # 5.5min |
There was a problem hiding this comment.
Timeout is wrong here. Should stay 330
There was a problem hiding this comment.
This is intended. As described above in the description both screensaver and hyprlock break the system idle state and effectively reset idle counters - thus, the original setting results in the wrong timeouts.
At least assuming that my interpretation of what is intended here is correct:
- Screensaver fires after 2.5 mins of inactivity.
- After the screen saver has fired, we wait another 2.5 mins (thus 5 mins of inactivity in total) to show the lock screen.
- After the lock screen fires up we wait 30s before dimming the screen.
I tested this on FW13 and Beelink SER9 - both work now exactly as specified above. Tested again today.
With the original settings you will have:
- Screensaver after 2.5 mins
- Lock screen after 7.5 mins of inactivity (5 min after screen saver fires up)
- Dimming the screen 5.5 min after the lock screen shows up (thus after 13 mins of inactivity).
This is because screen saver and hyper lock both reset the idle state counters, so basically after screen saver fires, it will count the whole 300 seconds again before showing the lock screen - thus 300s after the screensaver. Same for the hyperlock - after lock screen shows, with the original setting it will wait whole 330 seconds before dimming the screen - it is hard to believe this was the intention...
| listener { | ||
| timeout = 300 # 5min | ||
| on-timeout = loginctl lock-session # lock screen when timeout has passed | ||
| timeout = 150 # 5min |
There was a problem hiding this comment.
Timeout also wrong here. Should stray 300
| lock_cmd = omarchy-lock-screen # lock screen and 1password | ||
| before_sleep_cmd = loginctl lock-session # lock before suspend. | ||
| after_sleep_cmd = hyprctl dispatch dpms on # to avoid having to press a key twice to turn on the display. | ||
| on_unlock_cmd = hyprctl dispatch dpms on # make sure the screen is on when unlocking with fingerprint |
There was a problem hiding this comment.
I haven't been able to replicate a need for this. I tried after screen was off to authenticate with the fingerprint reader, and it correctly unlocked + turned on the screen.
Re: #641 Co-authored-by: @marcinczenko
Re: basecamp#641 Co-authored-by: @marcinczenko
This PR is fixing
twoone things:1. Makes omarchy bin visible to uwsm, by addinguwsm/env(see: https://wiki.hypr.land/Configuring/Environment-variables/). This makes the scriptsomarchy-*scripts referred in~/.config/hypr/hypridle.confvisible to hypridle - without this the screensaver will never start2.
Further aAdds a minor improvements to~/.config/hypr/hypridle.confso that the timing is correct (original config ignored that both screensaver and hyprlock break the system idle state and effectively reset idle counters), and also brings screen back after unlocking when it is caused by fingerprint (otherwise, the user would have black screen after unlocking with the fingerprint). Here, ideally we would also like to reset the idle counter here, but I do not see anyway of doing it easily.Not sure if added the migrations correctly.