Lock 1password right away, not after unlock#644
Merged
Conversation
Member
|
I think we need setsid too, so it doesn't quit when the shell running this script is done? |
Contributor
Author
|
From what I understand that is only necessary for interactive sessions. I think the process is orphaned and then inherited by init (systemd). In my local testing it definitively stays alive. |
Contributor
Author
|
Maybe it would be good to do it anyway, in case someone runs this from an interactive terminal session? |
Member
|
You're right, I don't think we need this. |
dhh
pushed a commit
to ryanrhughes/omarchy
that referenced
this pull request
Aug 22, 2025
marcinczenko
pushed a commit
to marcinczenko/omarchy
that referenced
this pull request
Sep 23, 2025
chriopter
pushed a commit
to chriopter/omarchy
that referenced
this pull request
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous script here had an error, it would only lock 1password once the lockscreen was terminated.
We still want to lock the screen first, but we mustn't wait for hyprlock to exit.
I've also backgrounded the 1password lock call, no need to wait for that either.