Fix About menu option not working#847
Closed
jardahrazdera wants to merge 1 commit into
Closed
Conversation
The About.desktop file exists but wasn't being deployed to users. Added migration to copy it to the applications directory where gtk-launch can find it. Users were clicking About in the menu but nothing happened because the desktop file wasn't in the expected location. Fixes basecamp#845
Member
|
Hmm, we need to get to the bottom of why it's actually failing. Otherwise people will just end up in the same situation again and this migration won't help them. |
dhh
added a commit
that referenced
this pull request
Aug 22, 2025
dhh
added a commit
to ryanrhughes/omarchy
that referenced
this pull request
Aug 22, 2025
OmarSkalli
pushed a commit
to OmarSkalli/omarchy
that referenced
this pull request
Aug 26, 2025
jakeprime
pushed a commit
to jakeprime/omarchy
that referenced
this pull request
Aug 26, 2025
gocs
pushed a commit
to gocs/omarchy
that referenced
this pull request
Aug 28, 2025
chriopter
pushed a commit
to chriopter/omarchy
that referenced
this pull request
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the About menu option that wasn't responding when clicked for some users.
Problem
The About.desktop file exists in the source but wasn't being deployed consistently to users. When users click About in the menu, gtk-launch can't find the desktop file, so nothing happens.
Root Cause
The install script uses
source omarchy-refresh-applications || truewhich can fail silently. Some users end up without About.desktop in their applications directory.Solution
Added a migration to ensure all users have About.desktop properly installed to ~/.local/share/applications/ where gtk-launch expects to find it.
Testing
After applying this migration:
Fixes #845