Skip to content

Expose $inputMethod to hyprland.conf#97

Closed
joonjeong wants to merge 1 commit into
basecamp:devfrom
joonjeong:dev
Closed

Expose $inputMethod to hyprland.conf#97
joonjeong wants to merge 1 commit into
basecamp:devfrom
joonjeong:dev

Conversation

@joonjeong
Copy link
Copy Markdown

@joonjeong joonjeong commented Jul 8, 2025

I use kime as Korean IME. fcitx5 is more general utility I know but kime is better user experience to me.

changing default ime is hard work, so I think it would be great if I changeable.

Copilot AI review requested due to automatic review settings July 8, 2025 18:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new $inputMethod variable to make the IME launch command configurable in Hyprland.

  • Adds a default $inputMethod = fcitx5 setting in the main config.
  • Replaces the hardcoded fcitx5 in the autostart file with the new $inputMethod variable.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
default/hypr/autostart.conf Swapped hardcoded fcitx5 for $inputMethod in the startup command
config/hypr/hyprland.conf Introduced $inputMethod variable with default fcitx5
Comments suppressed due to low confidence (2)

config/hypr/hyprland.conf:8

  • [nitpick] Consider adding a brief comment above this line explaining the purpose of $inputMethod and how users can override it in their personal Hyprland configuration.
$inputMethod = fcitx5

default/hypr/autostart.conf:1

  • [nitpick] For commands that include spaces or flags, consider wrapping $inputMethod in quotes (e.g., "$inputMethod") to prevent unintended word-splitting.
exec-once = hypridle & mako & waybar & $inputMethod

@joonjeong joonjeong changed the title Expose inputMethod to hyprland.conf Expose $inputMethod to hyprland.conf Jul 8, 2025
@dhh
Copy link
Copy Markdown
Member

dhh commented Jul 8, 2025

Hmm, good point. Can't merge this as-is, as it would break all existing installations, as hyprland.conf lives in .config (and isn't owned by Omarchy after installation). But I think we gotta think about how to get there. A hack in the short term would be to symlink kim as fcitx5 in your /usr/loca/bin.

@dhh dhh closed this Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants