Expose $inputMethod to hyprland.conf#97
Closed
joonjeong wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new $inputMethod variable to make the IME launch command configurable in Hyprland.
- Adds a default
$inputMethod = fcitx5setting in the main config. - Replaces the hardcoded
fcitx5in the autostart file with the new$inputMethodvariable.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| default/hypr/autostart.conf | Swapped hardcoded fcitx5 for $inputMethod in the startup command |
| config/hypr/hyprland.conf | Introduced $inputMethod variable with default fcitx5 |
Comments suppressed due to low confidence (2)
config/hypr/hyprland.conf:8
- [nitpick] Consider adding a brief comment above this line explaining the purpose of
$inputMethodand how users can override it in their personal Hyprland configuration.
$inputMethod = fcitx5
default/hypr/autostart.conf:1
- [nitpick] For commands that include spaces or flags, consider wrapping
$inputMethodin quotes (e.g.,"$inputMethod") to prevent unintended word-splitting.
exec-once = hypridle & mako & waybar & $inputMethod
Member
|
Hmm, good point. Can't merge this as-is, as it would break all existing installations, as hyprland.conf lives in .config (and isn't owned by Omarchy after installation). But I think we gotta think about how to get there. A hack in the short term would be to symlink kim as fcitx5 in your /usr/loca/bin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use kime as Korean IME. fcitx5 is more general utility I know but kime is better user experience to me.
changing default ime is hard work, so I think it would be great if I changeable.