Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors terminal palette detection to read/parse escape sequences incrementally until the DA1 “sentinel” is received (or a timeout closes the TTY), reducing buffering/coordination complexity and ensuring the sentinel response is consumed before exiting.
Changes:
- Replaced channel/goroutine-based buffering with a
detectorthat reads OSC/CSI sequences directly from abufio.Reader. - Updated detection flow to always wait for the DA1 sentinel (or stop on read error) and to close the TTY on timeout via a single cleanup path.
- Reworked tests to validate the new incremental reader behavior and the updated
detectFromsignature.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/ui/palette_detect.go | Implements the new incremental detector (OSC/CSI parsing), and changes timeout handling to close/restore the TTY via a single cleanup function. |
| internal/ui/palette_detect_test.go | Updates tests to exercise readNext/detector behavior and adjusts detectFrom call sites for the new API. |
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }) | ||
| defer cleanup() | ||
|
|
||
| time.AfterFunc(timeout, cleanup) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When detecting terminal colors at startup: